[HOLD App#11795] [$1000] Workspace - Invite new members list always scrolls to top after selecting 4 or more

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on avatar
2. Click on Workspace
3. Select Workspace
4. Click Manage Members
5. Click on Invite Members
6. Select at least 8 Members

Expected Result:

User should be able to view the most recent selected member

Actual Result:

List scrolls to top with first selected member

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.31-5
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.999.mp4

Screen.Recording.2022-11-24.at.5.13.20.PM.mov

Screen.Recording.2022-11-24.at.5.12.44.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @syedsaroshfarrukhdot
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1669292832144069

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0174a96dd459e1553d
• Upwork Job ID: 1598666700904955904
• Last Price Increase: 2022-12-08

[melvin-bot]

Triggered auto assignment to @davidcardoza (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[hungvu193]

I think this a feature, not a bug.

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 110 to 114 in 39b2f99

	// If we just toggled an option on a multi-selection page, scroll to top
	if (this.props.selectedOptions.length !== prevProps.selectedOptions.length) {
	this.scrollToIndex(0);
	return;
	}

App/src/components/OptionsSelector/BaseOptionsSelector.js

Line 120 in 39b2f99

this.scrollToIndex(this.state.focusedIndex);

In case we don't want it scroll to top (which's kind of annoying with me too) we can comment or delete this piece of code.

-            // If we just toggled an option on a multi-selection page, scroll to top
-           // if (this.props.selectedOptions.length !== prevProps.selectedOptions.length) {
-            //     this.scrollToIndex(0);
-            //     return;
-           // }
-           this.scrollToIndex(this.state.focusedIndex);

[melvin-bot]

@davidcardoza Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@davidcardoza Huh... This is 4 days overdue. Who can take care of this?

[davidcardoza]

Hmm...This feels like a bug, but I want a second opinion before moving forward with creating a job. Applying the engineering label.

[melvin-bot]

Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[davidcardoza]

@cristipaval thoughts?