Android - LHN - Fab menu is missing after log in

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Log in with any account
3. Check Green Plus button below

Expected Result:

Fub menu should be present

Actual Result:

Fub menu is missing in LHN

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Android

Version Number: 1.2.22.1

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20221031-161612_New.Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

cc @hannojg I think this might be related to the refactor #11907

[Julesssss]

I'm narrowing down the branch before reverting, as I want to be 100% sure.:

Nexus 5X, Android 8.1

• Production: not occurring ❌
• Staging: occurring ✅
• perf: memo SidebarLinks #11907: occurring ✅ <-- seems to have introduced the regression

[Julesssss]

THis PR reverts the PR that introduced this.