Look into making report display name generation more efficient

[tgolen]

Coming from #11226 (comment)

Problem

There is code that generates the display name of a report. This code may be non-performant at scale and turn into a bottle neck.

Solution

Consider some solutions:

1. memoizing the report name generation
2. generating the display name on the server
3. storing the displayName in a map instead of cloning the reports in a map

@marcaaron I'm particularly interested in your thoughts on solution 2. The report name will only change when:

1. The participants change (I don't think we ever change participants... We either archive the report or create a new report when adding participants
2. The type of chat report changes (I don't think it's possible to change the type of a chat report)
3. The chat is archived (valid reason)
4. The details of the participants change (valid reason)

Because of point 4, maybe that's the best reason to keep the display name generation on the client and to use solution 1 or 3 above?

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[michaelhaxhiu]

@tgolen would it be best to close this for and make an #expensify-open-source discussion/proposal? And then depending on what we discover there, we create a GH to handle next steps?

Just asking because as a triager, I'm struggling to assess my next step until this is definitively framed as a bug or newfeaure.

[michaelhaxhiu]

An alternative is to un-assign triage until it's ready for being pushed through the assignment flow. I'll leave it assigned for a few days till you have a moment to consider.

[marcaaron]

@tgolen report names can also be changed manually (in the case of user created rooms) so I'd add that case to the list

I like the idea of sending this from the backend as a new reportDisplayName field. Since we do not yet notify people in realtime when personal details change I don't think we can really do much about that point (until we have realtime updating of details and then should also update the report names when they change).

Overall, I think it is reasonable to send an updated reportDisplayName whenever one of the other things on your list happens.

[tgolen]

@michaelhaxhiu I think this is just a cleanup task that I'll work on internally. Sorry, I usually remember to omit the AutoAssignerTriage label when I do that :D