Deploy Checklist: New Expensify 2022-09-21

[OSBotify]

Release Version: 1.2.4-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Improvement BasePaymentPage #9622
• [Snyk] Security upgrade electron-builder from 23.3.1 to 23.5.0 #10740
• Optimize the left-hand-nav to only render options when they need to be visible #10800
• [No QA] Fix propType warning #11070
• Center align IOUDetails completed tick #11128
• Allow retryable optimistic workspace creation #11130
• Add Screenshot option for Safari mWeb #11142
• Fix multiple errors on set password page #11145
• Remove offline message from BaseOptionsSelector #11173
• [No QA] Fix syntax error in upload_symbols_to_crashlytics #11182
• Correct the Onyx beta key that sidebar connects to #11188

Internal QA:

• Add app_id for fastlane's upload_symbols_to_crashlytics Testflight build step #11154 - @francoisl @chiragsalian

Deploy Blockers:

• Correct the Onyx beta key that sidebar connects to #11188
• Android - Payments - Paypal account disappear if it was added offline #11203

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.4-1 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.4-1 has been deployed to staging 🎉

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.4-0 🚀

[luacmartins]

#11154 is a pass. Checking off.

[luacmartins]

Left a comment in #11203. Checking it off.

[luacmartins]

@mvtglobally what's the status on regression tests?

[mvtglobally]

Lol, just completed a sec ago.
All done

[luacmartins]

@mvtglobally awesome! Thanks for confirming. I'm gonna wait for #11188 to be CP'ed and test it myself before kicking off the deploy.

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.4-2 🚀