[HOLD for payment 2022-10-18] [$250] Offline- Profile - Unable to save first name, last name and time zone when user is offline

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log in any account
2. In the main testing device, Navigate to Settings > Profile
3. Disable the internet connection in the device
4. Modify first name, last name, and your timezone
5. Save and verify everything looks like it updated correctly
6. Go back online and verify the correct data is still in your profile

Expected Result:

When I'm offline I can change my profile details and save them

Actual Result:

Unable to save first name, last name and time zone when user is offline

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: v1.2.3-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5740969_2009_ios_1.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[francoisl]

The Save button is disabled when you're offline, so this order of operation doesn't seem possible:

4. Modify first name, last name, and your timezone
5. Save and verify everything looks like it updated correctly
6. Go back online and verify the correct data is still in your profile

In the video, it looks like you went back online first, right?

Anyway, it looks like the UpdateProfile command was implemented to be Pattern A, so it sounds right that we should let the user save the changes on the page even when they're offline.
The problem is that the ProfilePage uses a <Form>, which itself always uses a FormAlertWithSubmitButton, which disables the submit button when you're offline. I don't know of an alternative form component that doesn't use <FormAlertWithSubmitButton> but I'll take a look.

cc @Beamanator if you have any idea, I see you worked on the backend changes for UpdateProfile.

[Beamanator]

Ooh this is quite interesting and nice investigation @francoisl !

If we haven't already, I think we definitely need to build a way into the Form component (probably into the FormAlertWithSubmitButton component too) to allow the form to be submitted while offline

I just know the Form stuff was refactored & built before the Offline first push, so I'm sure this will come up over and over in the future if it hasn't already!

[francoisl]

Ok cool, thanks for the context. Looks like this could be a good contributor improvement opportunity.

[melvin-bot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.