iOS - Singin - The last link sent to reset your password shows an error

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Enter the login in the signin page
3. Make it send two password reset links
4. Use the old or expired link
5. Ensured appropriate error message is displayed and new link is received in email/sms
6. Used the latest link and updated password and it worked

Expected Result:

When following the last link we should not see the error of the previous link.

Actual Result:

The last link sent to reset your password shows an error

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS

Version Number: v1.2.3-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5740512_10969_ios.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @alex-mechler (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[luacmartins]

@kavimuru from the video at around 1:00, it seems like the tester selects the first email that was sent and not the one with the latest validation link (after they tapped Resend link). We will invalidate previous links whenever we generate a new one.

Can you please retest?

[alex-mechler]

Ah, thanks for pointing that out, that was going to be my first question 😅. This doesn't look like a bug provided the second link that we send works as expected.

[luacmartins]

@kavimuru I see that you removed the DeployBlockerCash label. Does that mean that this is working as expected?

[kavimuru]

@luacmartins It's happening in production too. So I removed deployblocker label. Yes, at the timeline 1:00 tapping the invalid link proper error message appears, then again when the latest link is tapped the same error message persistent. But able to set password with 2nd link as in the video.