[Tracking] [Performance] Margelo/Expensify - Performance Improvements

[trjExpensify]

Top Priorities

• [HOLD for payment 2023-01-19] [Performance] Use react-native-quick-sqlite instead of asyncStorage #10793 - @Szymon20000 @roryabraham
• [HOLD for payment 2023-01-09] [Tracking] Add performance CI tests #11711 @hannojg @AndrewGable
• [Tracking][Image][Polish] Image-related feature request and improvements #10894
• Image: support HTTP properties for 'source' objects necolas/react-native-web#1019
• [HOLD for payment][Bug] After typing even a mildly long comment in the Android compose box, the whole app starts to hang #11321 @Beamanator @hannojg

Other high-value items

• [$4000] Logo shifts to bottom (Bootsplash) when launched - reported by Ekram Khan #8236
• [$4000] [iOS] - Page freezes when creating New Group and selecting 8 members #9809
• [$250] Safari mWeb - Keyboard won't open for some inputs (New Chat, Change Password, New Room) #10414
• And a bunch of crashes we haven’t resolved yet.
• Add better performance metrics to Grafana #11997

Done

• [Performance] Optimise navigation  #10789 - @Szymon20000
• Optimize the left-hand-nav to only render options when they need to be visible #10800
• [No QA] Upgrade RN to 0.70.4 (aka 0.70.1) #10860
• [Performance] md5.js takes a lot of time #10794 - @Szymon20000 @aldo-expensify
• Replace _.merge function with faster alternative #11185 - @Szymon20000

[Szymon20000]

I would add:

• CI Tests (reassure, startup time)
• SideBarLinks
• HeaderView Doesn't use onyx context context (I think it's also the case with SideBarLinks) It means onyx will send them another copy od personalDetails as far as I know

[trjExpensify]

Awesome. Added those. Presumably they don't have issues to link yet, right? Outside of SideBarLinks, as @tgolen is working on PRs for that.

P.S - I can co-assign you this tracker now that you've commented. GH wasn't allowing me to do that yesterday.

[roryabraham]

Upgrade RN fork to 0.70

Finished this last week

[roryabraham]

@tgolen @Szymon20000 I know a lot of progress has been made on the LHN improvements, is there more to do here or should we check that off?

[tgolen]

I have a bunch of random cleanup items, but I feel pretty confident to check it off for now.

[roryabraham]

Update:

• [Performance] md5.js takes a lot of time #10794 is done
• The value of [HOLD for payment 2023-01-19] [Performance] Use react-native-quick-sqlite instead of asyncStorage #10793 is in question/unclear. I think we'll likely want to continue investigating this, but there's a lot of context in this thread
• dev: performance regression tests #11327 progress seems to have stalled, waiting for a summary of the CI stability issues from @hannojg
• Replace _.merge function with faster alternative – PR merged yesterday and published to npm in react-native-onyx@1.0.19. However, we need to bump the Onyx version in App to see this change take effect.
• Open and close the same chat again and again on Android native and it will gradually slow down for no reason – Last we heard, this was no longer reproducible, so I'm checking it off.
• HeaderView Doesn't use onyx context context (I think it's also the case with SideBarLinks) It means onyx will send them another copy of personalDetails as far as I know - nobody is assigned to this one, but there have been a few investigations into more low-level Onyx improvements, particularly by @marcaaron. I like the idea of trying to dynamically generate Onyx contexts within withOnyx so that we can use the context API for all subscribers universally.

[marcaaron]

@roryabraham In my PR to start using the modern "drawer" navigator I refactor the HeaderView a little so that the props are already available and passed via the ReportScreen - just minimizes a connection or two. I think a context based solution would be interesting though but had trouble thinking of how it would work.