Android - Workspace settings - Input fields are not grayed out when made changes offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the App and login
2. Click on Create a New Workspace
3. Navigate to the General settings page
4. Disable the internet connection
5. Change the workspace currency and name
6. Save the changes

Expected Result:

Input fields should be grayed out when saved changes offline

Actual Result:

Input fields are not grayed out when made changes offline

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.97.2

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5718910_video_2022-09-05_21-54-02.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[chiragsalian]

Not really a blocker. I think this is fine since we'll now allow updating the workspace name optimistically even when offline so this seems normal to me. cc @neil-marcellini as well since you made this change.

I tested on staging and it looks good to me as is.

[luacmartins]

I agree that this is not a blocker since it's just UI and doesn't prevent the user from using the App. I was also not able to reproduce this locally. Removing the blocker label.

[neil-marcellini]

Was cellular data turned off when "going offline"? The offline indicator did not appear. @kbecciv can you please try again and make sure that cellular data is off?

[kbecciv]

@neil-marcellini Checking with team, will update you shortly.