[HOLD for payment 2022-09-15] [$250] Chat - Error message is received when attaching files with extension in caps

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Access staging.new.expensify.com
2. Sign into a valid account
3. Open any chat
4. Attempt to add any attachment through "+" or "Drag & Drop" with the type in CAPS (For example: .PDF or .PNG)

Expected Result:

User expects the attachment to be added with no issues

Actual Result:

The user receives an error message if the attachment type is in CAPS

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• Desktop App

Version Number: 1.1.94-4
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5710801_PNG_leads_to_error.mp4

Upwork URL https://www.upwork.com/jobs/~01d1500d5c8671f017
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[theTrozen77]

PROPOSAL

I was able to reproduce the issue and fix it.
It is a simple fix. Just convert the extension string to lowercase using .toLowerCase() method when the file extension is separated from the complete file string.
const fileExtension = splitFileName.pop().toLowerCase();

Thankyou

[varshamb]

Proposal

Previous proposal modifies the extension, but I think we should only convert to lowercase during validation.

App/src/components/AttachmentModal.js

Line 169 in 0229523

if (!_.contains(CONST.API_ATTACHMENT_VALIDATIONS.ALLOWED_EXTENSIONS, fileExtension)) {

[melvin-bot]

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[trjExpensify]

Woof, nice catch. Job is on Upwork here: https://www.upwork.com/jobs/~01d1500d5c8671f017

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)