[Pending Payment] [$250] Web/Desktop - Workspace settings side menu does not open after creating workspace

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to staging and login
2. Create Workspace

Expected Result:

Workspace should be created and side menu Workspace settings should be open.

Actual Result:

Workspace is created but side menu Workspace settings isn't open. Only popup appeared.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web

Version Number: v1.1.93-4
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5709463_WS.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[joelbettner]

I think we can make this an external.

[melvin-bot]

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[jayeshmangwani]

Proposal

we need to pass the array in this Promise.all in create function

App/src/libs/actions/Policy.js

Lines 136 to 144 in 22a0cba

	return Promise.all(
	Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${response.policyID}`, {
	id: response.policyID,
	type: response.policy.type,
	name: response.policy.name,
	role: CONST.POLICY.ROLE.ADMIN,
	outputCurrency: response.policy.outputCurrency,
	}),
	Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY_MEMBER_LIST}${response.policyID}`, getSimplifiedEmployeeList(response.policy.employeeList)),

+return Promise.all([
  Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${response.policyID}`, {
      id: response.policyID,
      type: response.policy.type,
      name: response.policy.name,
      role: CONST.POLICY.ROLE.ADMIN,
      outputCurrency: response.policy.outputCurrency,
  }),
  Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY_MEMBER_LIST}${response.policyID}`, getSimplifiedEmployeeList(response.policy.employeeList)),
+]);

issue-10665.mov

[trjExpensify]

Adding yah back for CM, @NicMendonca.

[NicMendonca]

job post: https://www.upwork.com/jobs/~0166853faf8e443072