Web- Workspace - When tapping "back", user is taken to VBA flow again

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Access staging.new.expensify.com
2. Sign into a valid account
3. Create a workspace
4. Tap on the Profile icon > Workspace name > Reimburse expenses > connect to bank
5. Tap "back" on the "Continue with setup" page

Expected Result:

User expects to be returned to the previous Reimburse expenses page. (Works for any of the options in the workspace, reimburse expenses is just an example)

Actual Result:

The user is redirected to a second VBA flow showing the "Connect online with plaid/manual" options

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• Mobile Web

Version Number: 1.1.91.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5704602_When_tapping_Back_user_is_redirected_twice_to_VBA.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[luacmartins]

I confirmed that this happens in staging but not in prod.

[jasperhuangg]

No idea why this is happening, reached out in #engineering-chat for some help

[luacmartins]

Git bisect tells me this is the offending commit but I have no idea why

[luacmartins]

Hmm maybe I did something wrong along the way haha reverting those changes doesn't seem to fix the issue

[jasperhuangg]

#10454 isn't included in this deploy checklist but is only on staging at the moment, feel like that's probably what's causing the problem because it's the only thing that's modified the WorkspaceBankAccountPage recently cc @luacmartins

actually, I reverted out those changes locally and tested and it still doesn't solve the problem 😟

[jasperhuangg]

Git bisect tells me this is the offending commit but I have no idea why

@luacmartins yeah I have no idea how changing KeyboardAvoidingView behavior would change that.. I don't think that's the reason either.

[luacmartins]

#10454 is actually on prod (we must have missed the deploy comment)

[jasperhuangg]

It appears this issue is being caused by #10026, specifically the new logic that stores pending routes. cc @robertjchen

I'm going to revert!