[HOLD for payment 2022-09-01] [$250] iOS - Random avatar color changes after creating a group for a new user

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue was found when executing #9963

Action Performed:

1. Click FAB > New Group
2. Select a user you've never had a chat with
3. Add 2 more users and create a group

Expected Result:

Randomly generated avatar color should be same when selecting a user to create a group and after group chat initiated

Actual Result:

Avatar color is different in the group chat than initially selected

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS

Version Number: 1.1.87-8

Reproducible in staging?: y

Reproducible in production?: y

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5673400_DHBY0250_1_.mp4

Expensify/Expensify Issue URL:

Issue reported by:
Applause internal team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[eVoloshchak]

When you are entering the name on the New Group page, name starts with an uppercase letter. When you're on Details page, name starts with a lowercase letter. getDefaultAvatar is case sensitive, those are two different names, hence two different colors.

If that is not the expected behavior, all that's needed is changing this line in getDefaultAvatar

function getDefaultAvatar(login = '') {
    // There are 8 possible default avatars, so we choose which one this user has based
    // on a simple hash of their login (which is converted from HEX to INT)
-   const loginHashBucket = (parseInt(md5(login).substring(0, 4), 16) % 8) + 1;
+   const loginHashBucket = (parseInt(md5(login.toLowerCase()).substring(0, 4), 16) % 8) + 1;
    return `${CONST.CLOUDFRONT_URL}/images/avatars/avatar_${loginHashBucket}.png`;
}

[melvin-bot]

Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

@stephanieelliott Huh... This is 4 days overdue. Who can take care of this?

[stephanieelliott]

Hey @kavimuru, heads up we skipped a few steps with this one - this (and all new issues) should get the Auto Assigner Triage label first, then the assigned triager will apply the Engineering label 😊.