[HOLD for payment 2022-11-24] [$1000] Composer text and icon not aligned vertically centre for native app - reported by dhairyasenjaliya

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login in iOS app
2. Go to any chat
3. Type message in composer and notice the send icon and text written is aligned more to bottom rather than centre vertically

Expected Result:

Text should be proper aligned to vertically centre

Actual Result:

Text not aligned to vertically centre

Workaround:

unknown

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number: 1.1.86-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Upwork job URL: https://www.upwork.com/jobs/~01b7d0ca259c9797ca
Issue reported by: dhairyasenjaliya @roryabraham
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1657875961211239
https://expensify.slack.com/archives/C01GTK53T8Q/p1659011710209859

View all open jobs on GitHub

[melvin-bot]

Current assignee @Julesssss is eligible for the Engineering assigner, not assigning anyone new.

[melvin-bot]

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[trjExpensify]

For the avoidance of doubt, can we confirm in the OP for the contributor what the padding should be? it's 6px top and bottom isn't it? CC: @shawnborton

I'm also curious what PR broke this, I took a cursory look at recent ones and perhaps this?

[thesahindia]

I took a cursory look at recent ones and perhaps this?

I don't think it's related because that PR is only related to edit composer.

[shawnborton]

I agree that it's not vertically aligned. I think we want some default padding on top and bottom, but regardless, the text should be vertically aligned in the remaining space. There is a way to do this easily on Android I believe, but I'm not sure how we do it on iOS.

[roryabraham]

Heads up! It looks like there are actually two (potentially separate) alignment issues at play here:

1. Text misalignment

   

2. Icon misalignment

   

[Julesssss]

Thanks Rory. I recalled an existing issue for the icon, but can't find anything in our open issues 🤷

I updated the description and title to include both issues and will open up for contributors.