Skip to content

Bug in Functional command service. #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexeyzimarev merged 1 commit into from
Jun 20, 2025
Merged

Bug in Functional command service. #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Core/src/Eventuous.Application/FunctionalService/CommandService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public async Task<Result<TState>> Handle<TCommand>(TCommand command, Cancellatio
var result = (await registeredHandler.Handler(loadedState.State, loadedState.Events, command, cancellationToken).NoContext()).ToArray();

var newEvents = result.Select(x => new ProposedEvent(x, new())).ToArray();
var newState = newEvents.Aggregate(loadedState.State, (current, evt) => current.When(evt));
var newState = newEvents.Aggregate(loadedState.State, (current, evt) => current.When(evt.Data));

// Zero in the global position would mean nothing, so the receiver needs to check the Changes.Length
if (newEvents.Length == 0) return Result<TState>.FromSuccess(newState, Array.Empty<Change>(), 0);
Expand Down