Skip to content

Avoid "stream not found" log message when it is expected#403

Merged
alexeyzimarev merged 2 commits intodevfrom
swallow-transient-warnings
Mar 3, 2025
Merged

Avoid "stream not found" log message when it is expected#403
alexeyzimarev merged 2 commits intodevfrom
swallow-transient-warnings

Conversation

@alexeyzimarev
Copy link
Copy Markdown
Contributor

Command services support executing a command with expected stream version Any. However, the store still produces a log message when it reads a non-existent stream.
This PR makes the log message disappear along with the exception, if it is expected that there's no stream. Stores should return an empty result when the stream is not found.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2025

Test Results

 28 files  + 14   28 suites  +14   1h 21m 1s ⏱️ + 53m 23s
193 tests +  1  193 ✅ +  1  0 💤 ±0  0 ❌ ±0 
388 runs  +194  388 ✅ +194  0 💤 ±0  0 ❌ ±0 

Results for commit ea7f472. ± Comparison against base commit e4769af.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(CommitPositionSequence, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2025-01-30T09:25:09.0819222+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(CommitPositionSequence, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2025-03-03T16:49:14.1935502+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(CommitPositionSequence, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2025-03-03T16:49:25.2561705+00:00 })

♻️ This comment has been updated with latest results.

@alexeyzimarev alexeyzimarev merged commit df72c08 into dev Mar 3, 2025
4 checks passed
@alexeyzimarev alexeyzimarev deleted the swallow-transient-warnings branch March 3, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant