Avoid "stream not found" log message when it is expected#403
Merged
alexeyzimarev merged 2 commits intodevfrom Mar 3, 2025
Merged
Avoid "stream not found" log message when it is expected#403alexeyzimarev merged 2 commits intodevfrom
alexeyzimarev merged 2 commits intodevfrom
Conversation
Test Results 28 files + 14 28 suites +14 1h 21m 1s ⏱️ + 53m 23s Results for commit ea7f472. ± Comparison against base commit e4769af. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command services support executing a command with expected stream version
Any. However, the store still produces a log message when it reads a non-existent stream.This PR makes the log message disappear along with the exception, if it is expected that there's no stream. Stores should return an empty result when the stream is not found.