Skip to content

Simplify command services#350

Merged
alexeyzimarev merged 9 commits intodevfrom
cmd-services
Jun 20, 2024
Merged

Simplify command services#350
alexeyzimarev merged 9 commits intodevfrom
cmd-services

Conversation

@alexeyzimarev
Copy link
Copy Markdown
Contributor

  • Single abstraction for command services
  • Simplified HTTP command result
  • Removed aggregate without state

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 17, 2024

Test Results

 36 files  + 18   36 suites  +18   7m 15s ⏱️ + 3m 52s
159 tests +  1  159 ✅ +  1  0 💤 ±0  0 ❌ ±0 
314 runs  +156  314 ✅ +156  0 💤 ±0  0 ❌ ±0 

Results for commit 6501e62. ± Comparison against base commit 0356301.

This pull request removes 6 and adds 7 tests. Note that renamed tests count towards both.
Eventuous.Tests.AspNetCore.Web.AggregateCommandsTests ‑ MapAggregateContractToCommandExplicitly<BookingResult>(tResult: BookingResult { State = , Success = False, Changes = , State =  })
Eventuous.Tests.AspNetCore.Web.AggregateCommandsTests ‑ MapAggregateContractToCommandExplicitly<Result>(tResult: Result { State = , Success = False, Changes =  })
Eventuous.Tests.AspNetCore.Web.AggregateCommandsTests ‑ MapContractToCommandExplicitly<BookingResult>(tResult: BookingResult { State = , Success = False, Changes = , State =  })
Eventuous.Tests.AspNetCore.Web.AggregateCommandsTests ‑ MapContractToCommandExplicitly<Result>(tResult: Result { State = , Success = False, Changes =  })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-17T11:26:29.1189326+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-17T11:26:29.1189326+00:00 }, CommitPosition { Position: 0, Sequence: 4, Timestamp: 2024-06-17T11:26:29.1189326+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-17T11:26:29.1189326+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-17T11:26:29.1189326+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-17T11:26:29.1189326+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-17T11:26:29.1189326+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-17T11:26:29.1189326+00:00 }, CommitPosition { Position: 0, Sequence: 8, Timestamp: 2024-06-17T11:26:29.1189326+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-17T11:26:29.1189326+00:00 })
Eventuous.Tests.AggregateWithId.OperateOnAggregateWithId ‑ should_emit_event
Eventuous.Tests.AggregateWithId.OperateOnAggregateWithId ‑ should_set_id
Eventuous.Tests.AspNetCore.Web.AggregateCommandsTests ‑ MapAggregateContractToCommandExplicitly
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-20T15:25:59.7434491+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-20T15:25:59.7434491+00:00 }, CommitPosition { Position: 0, Sequence: 4, Timestamp: 2024-06-20T15:25:59.7434491+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-20T15:25:59.7434491+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-20T15:25:59.7434491+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-20T15:25:59.7434491+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-20T15:25:59.7434491+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-20T15:25:59.7434491+00:00 }, CommitPosition { Position: 0, Sequence: 8, Timestamp: 2024-06-20T15:25:59.7434491+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-20T15:25:59.7434491+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-20T15:26:00.5083079+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-20T15:26:00.5083079+00:00 }, CommitPosition { Position: 0, Sequence: 4, Timestamp: 2024-06-20T15:26:00.5083079+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-20T15:26:00.5083079+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-20T15:26:00.5083079+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-20T15:26:00.5083079+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-20T15:26:00.5083079+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-20T15:26:00.5083079+00:00 }, CommitPosition { Position: 0, Sequence: 8, Timestamp: 2024-06-20T15:26:00.5083079+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-20T15:26:00.5083079+00:00 })

♻️ This comment has been updated with latest results.

@alexeyzimarev alexeyzimarev merged commit 58b05ff into dev Jun 20, 2024
@alexeyzimarev alexeyzimarev deleted the cmd-services branch June 20, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants