Skip to content

Use keyed dependencies to isolate event handlers in subscriptions#342

Merged
alexeyzimarev merged 5 commits intodevfrom
multiple-transforms
Jun 16, 2024
Merged

Use keyed dependencies to isolate event handlers in subscriptions#342
alexeyzimarev merged 5 commits intodevfrom
multiple-transforms

Conversation

@alexeyzimarev
Copy link
Copy Markdown
Contributor

@alexeyzimarev alexeyzimarev commented Jun 13, 2024

Fixes #250

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 13, 2024

Test Results

 54 files  + 36   54 suites  +36   10m 53s ⏱️ + 7m 38s
162 tests +  4  162 ✅ +  4  0 💤 ±0  0 ❌ ±0 
474 runs  +316  474 ✅ +316  0 💤 ±0  0 ❌ ±0 

Results for commit a4ccb80. ± Comparison against base commit f3d8029.

This pull request removes 2 and adds 6 tests. Note that renamed tests count towards both.
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-13T12:55:37.0893890+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-13T12:55:37.0893890+00:00 }, CommitPosition { Position: 0, Sequence: 4, Timestamp: 2024-06-13T12:55:37.0893890+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-13T12:55:37.0893890+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-13T12:55:37.0893890+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-13T12:55:37.0893890+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-13T12:55:37.0893890+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-13T12:55:37.0893890+00:00 }, CommitPosition { Position: 0, Sequence: 8, Timestamp: 2024-06-13T12:55:37.0893890+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-13T12:55:37.0893890+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-14T16:41:00.1133258+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-14T16:41:00.1133258+00:00 }, CommitPosition { Position: 0, Sequence: 4, Timestamp: 2024-06-14T16:41:00.1133258+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-14T16:41:00.1133258+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-14T16:41:00.1133258+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-14T16:41:00.1133258+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-14T16:41:00.1133258+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-14T16:41:00.1133258+00:00 }, CommitPosition { Position: 0, Sequence: 8, Timestamp: 2024-06-14T16:41:00.1133258+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-14T16:41:00.1133258+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-14T16:41:00.9618319+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-14T16:41:00.9618319+00:00 }, CommitPosition { Position: 0, Sequence: 4, Timestamp: 2024-06-14T16:41:00.9618319+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-14T16:41:00.9618319+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-14T16:41:00.9618319+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-14T16:41:00.9618319+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-14T16:41:00.9618319+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-14T16:41:00.9618319+00:00 }, CommitPosition { Position: 0, Sequence: 8, Timestamp: 2024-06-14T16:41:00.9618319+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-14T16:41:00.9618319+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-16T08:52:13.2952017+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-16T08:52:13.2952017+00:00 }, CommitPosition { Position: 0, Sequence: 4, Timestamp: 2024-06-16T08:52:13.2952017+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-16T08:52:13.2952017+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-16T08:52:13.2952017+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-16T08:52:13.2952017+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-16T08:52:13.2952017+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-16T08:52:13.2952017+00:00 }, CommitPosition { Position: 0, Sequence: 8, Timestamp: 2024-06-16T08:52:13.2952017+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-16T08:52:13.2952017+00:00 })

♻️ This comment has been updated with latest results.

@alexeyzimarev alexeyzimarev changed the title Quick fix for multiple gateway transforms Use keyed dependencies to isolate event handlers in subscriptions Jun 14, 2024
@alexeyzimarev alexeyzimarev merged commit fb15ac3 into dev Jun 16, 2024
@alexeyzimarev alexeyzimarev deleted the multiple-transforms branch June 16, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot use more than one gateway transformation

1 participant