Skip to content

Cleaning up HTTP results#294

Merged
alexeyzimarev merged 1 commit intodevfrom
action-result
Nov 17, 2023
Merged

Cleaning up HTTP results#294
alexeyzimarev merged 1 commit intodevfrom
action-result

Conversation

@alexeyzimarev
Copy link
Copy Markdown
Contributor

  • Consolidated return types
  • Use extensions instead of duplicated code
  • Removed unnecessary generic constraints

@github-actions
Copy link
Copy Markdown

Test Results

37 tests   - 99   37 ✔️  - 97   2s ⏱️ - 3m 43s
  2 suites  - 46     0 💤 ±  0 
  2 files    - 46     0  -   2 

Results for commit 36bda3b. ± Comparison against base commit 134b66c.

This pull request removes 101 and adds 2 tests. Note that renamed tests count towards both.
Eventuous.Tests.Application.FunctionalServiceTests ‑ AmendEventAddsMeta
Eventuous.Tests.Application.FunctionalServiceTests ‑ ExecuteOnAnyForNewStream
Eventuous.Tests.Application.FunctionalServiceTests ‑ ExecuteOnExistingStream
Eventuous.Tests.Application.FunctionalServiceTests ‑ ExecuteOnNewStream
Eventuous.Tests.Application.StateWithIdTests ‑ ShouldGetIdForNew
Eventuous.Tests.AspNetCore.AggregateFactoryRegistrationTests ‑ ShouldCreateNewAggregateByResolve
Eventuous.Tests.AspNetCore.AggregateFactoryRegistrationTests ‑ ShouldCreateNewAggregateWithExplicitFunction
Eventuous.Tests.AspNetCore.AggregateFactoryRegistrationTests ‑ ShouldCreateTwoSeparateInstances
Eventuous.Tests.AspNetCore.Web.AggregateCommandsTests ‑ MapAggregateContractToCommandExplicitly<BookingResult>(tResult: BookingResult { State = , Success = False, Changes = , State =  })
Eventuous.Tests.AspNetCore.Web.AggregateCommandsTests ‑ MapAggregateContractToCommandExplicitly<Result>(tResult: Result { State = , Success = False, Changes =  })
…
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2023-11-17T08:55:07.5975544+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-11-17T08:55:07.5975544+00:00 }, CommitPosition { Position: 0, Sequence: 4, Timestamp: 2023-11-17T08:55:07.5975544+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2023-11-17T08:55:07.5975544+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-11-17T08:55:07.5975544+00:00 })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2023-11-17T08:55:07.5975544+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-11-17T08:55:07.5975544+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2023-11-17T08:55:07.5975544+00:00 }, CommitPosition { Position: 0, Sequence: 8, Timestamp: 2023-11-17T08:55:07.5975544+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-11-17T08:55:07.5975544+00:00 })

Copy link
Copy Markdown
Contributor

@LockTar LockTar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far I can see this will work in our situation! Nice refactoring! Good that some files are gone now.

@alexeyzimarev alexeyzimarev merged commit e51050e into dev Nov 17, 2023
@alexeyzimarev alexeyzimarev deleted the action-result branch November 17, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants