Skip to content

Changing PostgresStreamSubscriptionOptions.Stream to be mutable#236

Merged
alexeyzimarev merged 4 commits intoEventuous:devfrom
matt-lethargic:dev
Aug 18, 2023
Merged

Changing PostgresStreamSubscriptionOptions.Stream to be mutable#236
alexeyzimarev merged 4 commits intoEventuous:devfrom
matt-lethargic:dev

Conversation

@matt-lethargic
Copy link
Copy Markdown
Contributor

Changing PostgresStreamSubscriptionOptions.Stream to be mutable, this now is more in-line with how the documentation outlines it's usage:

builder.Services.AddSubscription<PostgresStreamSubscription, PostgresStreamSubscriptionOptions>(
    "StreamSubscription",
    builder => builder
        .Configure(x => x.StreamName = "my-stream")
        .AddEventHandler<StreamSubscriptionHander>()
);

but the document should now be:

builder.Services.AddSubscription<PostgresStreamSubscription, PostgresStreamSubscriptionOptions>(
    "StreamSubscription",
    builder => builder
        .Configure(x => x.StreamName = new StreamName("my-stream"))
        .AddEventHandler<StreamSubscriptionHander>()
);

and is now closer to how StreamPersistentSubscriptionOptions is created.

(documentation site will need a PR if this is accepted)

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 14, 2023

CLA assistant check
All committers have signed the CLA.

@alexeyzimarev alexeyzimarev merged commit 3ffed4c into Eventuous:dev Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants