Merged
Conversation
Contributor
|
Would be nice to have a test that appends and then reads the event. Seems like reads aren't covered in tests. For some reason I had an impression that your fork had tests for reads? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Alexey,
I created a version of the Redis event store that is using a Redis function to add events to streams and to the _all stream in a single transaction. As per Redis documentation (https://redis.io/docs/manual/programmability/functions-intro/#what-are-redis-functions):
"Like all other operations in Redis, the execution of a function is atomic. A function's execution blocks all server activities during its entire time, similarly to the semantics of transactions."
I've created just the event store and corresponding tests, but if you think this is worth adding to the main repo, then I can add the additional parts, e.g. subscriptions and producers.