Skip to content

Implement proper support for npgsql7#188

Merged
alexeyzimarev merged 3 commits intoEventuous:devfrom
fbjerggaard:support-npgsql-7
Apr 5, 2023
Merged

Implement proper support for npgsql7#188
alexeyzimarev merged 3 commits intoEventuous:devfrom
fbjerggaard:support-npgsql-7

Conversation

@fbjerggaard
Copy link
Copy Markdown
Contributor

Fixes #182

Replaces #183

Requires some documentation changes:

Configure with

builder.Services.ConfigureEventuousPostgres(connString)
// or
builder.Services.ConfigureEventuousPostgres(connString, pgOptions)

instead of

NpgsqlConnection GetConnection() => new(connectionString);

builder.Services.AddSingleton((GetPostgresConnection)GetConnection);

All tests are passing

@fbjerggaard fbjerggaard marked this pull request as ready for review February 11, 2023 17:39
@alexeyzimarev
Copy link
Copy Markdown
Contributor

Sorry for a delay with merging this, I was long under an impression that it's still a draft. Is it ready? Can I merge it now?

@fbjerggaard
Copy link
Copy Markdown
Contributor Author

No worries - I could have written that it was ready.

I have been using it in a test environment for the past month, and so far it seems to be working as intended and all tests are passing, so it should be good to merge

@alexeyzimarev alexeyzimarev self-requested a review April 5, 2023 16:12
@alexeyzimarev alexeyzimarev merged commit 4f6c906 into Eventuous:dev Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eventuous breaks with npgsql >= 7.0.0

3 participants