append_events procedure is missing a transaction

[nmummau]

I noticed that SQL Server's append_events procedure is missing a transaction.

SqlServer.Rules : Wrap multiple action statements within a transaction. (https://github.com/ErikEJ/SqlServer.Rules/blob/master/docs/Design/SRD0009.md)

The problem this causes:
If the INSERT into the [Messages] table succeeds, it's possible that the UPDATE to the [Streams] table might fails. Without a transaction, the INSERT will not be rolled back.

[linear]

EVE-200 append_events procedure is missing a transaction

[nmummau]

@alexeyzimarev have you given any thought to this and looked over the append_events procedure in question? To me this seems like it could cause issues in the database that would require intervention to get the data corrected.

Is a transaction intentionally omitted in this procedure for some reason?

[nmummau]

I have a fix in the works for this. Waiting on the other mssql PR to merge before I propose something here.

[alexeyzimarev]

Yes, I believe you're right. Again, SQL Server and Postgres implementations are external contributions and I am not using these components myself. Happy to accept the fix.