Fix stack trace when buying from sign when inventory full#5761
Merged
pop4959 merged 1 commit intoEssentialsX:2.xfrom Apr 13, 2024
rymiel:fix-5736-mistake
Merged
Fix stack trace when buying from sign when inventory full#5761pop4959 merged 1 commit intoEssentialsX:2.xfrom rymiel:fix-5736-mistake
pop4959 merged 1 commit intoEssentialsX:2.xfrom
rymiel:fix-5736-mistake
Conversation
PR #5736 made ChargeException implement TranslatableException and in doing so, changed the meaning of its constructor. However there were 2 uses of that constructor that did not pass a locale key as is expected now, and instead passed in a regular string. These 2 uses are when you attempt to use a buy sign or a trade sign, and the operation fails because your inventory is full. This causes the translator to blow up and put an error trace in the console, as EssentialsX's translator has no fallbacks. There were no other perceivable issues other than the console spam. This PR also resolves a TODO.
mbax
approved these changes
Apr 13, 2024
pop4959
added
type: bugfix
pop4959
approved these changes
Apr 13, 2024
Member
|
Denied, thanks for your contribution. |
HarvelsX
pushed a commit
to HarvelsX/Essentials
that referenced
this pull request
Jun 2, 2024
Starmism
pushed a commit
to valence-smp/Essentials
that referenced
this pull request
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #5736 made
ChargeExceptionimplementTranslatableExceptionand in doing so, changed the semantics of its constructor. However there were 2 uses of that constructor that did not pass a locale key as is expected now, and instead passed in a regular string. These 2 uses are when you attempt to use a buy sign or a trade sign, and the operation fails because your inventory is full.This causes the translator to blow up and put an error trace in the console, as EssentialsX's translator has no fallbacks. There were no other perceivable issues other than the console spam.
This PR also resolves a TODO.