Don't run keyword replacer by default in translated broadcasts#5739
Merged
JRoy merged 3 commits intoEssentialsX:2.xfrom Mar 25, 2024
Merged
Don't run keyword replacer by default in translated broadcasts#5739JRoy merged 3 commits intoEssentialsX:2.xfrom
JRoy merged 3 commits intoEssentialsX:2.xfrom
Conversation
pop4959
added
type: bugfix
JRoy
approved these changes
Mar 25, 2024
HarvelsX
pushed a commit
to HarvelsX/Essentials
that referenced
this pull request
Jun 2, 2024
…tialsX#5739) Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Starmism
pushed a commit
to valence-smp/Essentials
that referenced
this pull request
Jan 8, 2025
…tialsX#5739) Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of the other
broadcastTlmethods run a keyword replacer by default, and this breaks behavior with newlines, etc, in several places (technically this specific overload is only used in /broadcast and /me, both work as intended after this change).My assumption is that this is unintended, and a regression introduced with the adventure merge.
Fixes #5716