Fix banner patterns not working in kits#5723
Merged
JRoy merged 2 commits intoEssentialsX:2.xfrom Mar 4, 2024
Merged
Conversation
Function PatternType.valueOf was not the appropriate function for finding the PatternType by the identifier. I replaced with the the appropriate function getByIdentifier.
JRoy
approved these changes
Mar 4, 2024
JRoy
changed the title
HarvelsX
pushed a commit
to HarvelsX/Essentials
that referenced
this pull request
Jun 2, 2024
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Starmism
pushed a commit
to valence-smp/Essentials
that referenced
this pull request
Jan 8, 2025
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Information
This PR fixes #4737.
Details
Proposed fix:
Function PatternType.valueOf was not the appropriate function for finding the PatternType by the identifier. I replaced with the the appropriate function "getByIdentifier".
Environments tested:
OS: Windows 11
Java version: 1.8.0_51
Demonstration:
Before:
After:
