Login window instead of WWW-Authenticate by whisperity · Pull Request #1301 · Ericsson/codechecker

whisperity · 2018-01-17T15:56:23Z

Closes #1220.

Instead of prompting the user for WWW-Authenticate (the normal browser popup window authentication), use a facade put together in Dojo to ask for user credentials. This way, it is the Thrift API that handles the login of the user, the same way the command-line client does it.

Browsers cache the credentials of a Authenticate header which is very hacky to remove. Thanks to dropping that whole functionality, we can now introduce a Log out feature, which this patch also does.

csordasmarton · 2018-01-18T10:25:05Z

www/style/login.css

+  font-size: 12pt;
+  display: inline-block;
+  margin-bottom: 18px;
+}


No new line at the end of file.

csordasmarton · 2018-01-18T10:32:57Z

www/scripts/login/login.js

+    document.body.appendChild(layout.domNode);
+    layout.startup();
+  };
+});


No new line at the end of this file.

csordasmarton · 2018-01-18T10:39:41Z

www/login.html

+  <!-- CSS -->
+
+  <link type="text/css" rel="stylesheet" href="scripts/plugins/dojo/dijit/themes/claro/claro.css" />
+  <link type="text/css" rel="stylesheet" href="scripts/plugins/dojo/dojox/form/resources/CheckedMultiSelect.css"/>


Do not import CheckedMultiSelect, claroGrid, jsPlumb, marked.min. We do not use these at the login page.

csordasmarton · 2018-01-18T10:42:30Z

www/scripts/login/login.js

+
+      this.btnSubmit = new Button({
+        label   : "Login",
+        onClick : function () {


It would be great to fire this event by pressing ENTER button.

csordasmarton · 2018-01-18T10:56:42Z

Login in and after log out from the product page will result a blank page.

whisperity · 2018-01-23T16:03:30Z

Rebased TOT for the minor refactoring work introduced in #1172.

csordasmarton · 2018-01-29T12:00:57Z

libcodechecker/server/server.py

+
+        product_endpoint, path = routing.split_client_GET_request(self.path)
+
+        if self.server.manager.isEnabled() and not auth_session \


SessionManager instance has no attribute 'isEnabled'

Use is_enabled property instead of this.

csordasmarton · 2018-01-29T12:53:08Z

www/scripts/login/login.js

+      this.btnSubmit = new Button({
+        label   : "Login",
+        onClick : function () {
+          that._doLogin();


If the login has failed, do not clear the username field and put the focus on the password input field.

If I click on the login button the authentication takes too much time. It would be great to use a dojo stand by (https://dojotoolkit.org/reference-guide/1.10/dojox/widget/Standby.html) to show that the operation is in process.

First comment fixed.

Second I will look into later, no time to do right now. Also, should the authentication really be that slow?

csordasmarton · 2018-01-29T13:10:37Z

www/scripts/login/login.js

+      region : 'center',
+      postCreate : function () {
+         var smallerContainer = domConstruct.create('div', {
+           class : 'login-form'


Use id instead of class

csordasmarton · 2018-01-29T13:18:02Z

www/style/login.css

@@ -0,0 +1,15 @@
+.login-form {


Use this:

#login-form { display: block; position: relative; top: 25%; margin: 0 auto; width: 20%; background-color: #edf4fa; border: 1px solid; border-color: #e5e6e9 #dfe0e4 #d0d1d5; border-radius: 5px; } #login-form .mbox.mbox-error { background-color: white; } #login-form .login-prompt { font-weight: bold; font-size: 12pt; display: inline-block; margin-bottom: 18px; } #login-form .formElement .form-input { width: 100%; }

You sure we want it to look like this?

The prompt for access is getting wrapped. If the window is small, this happens:

You can use the min-width css property to set a minimal width for the login form.

csordasmarton · 2018-01-29T13:27:24Z

www/scripts/login/login.js

+
+          var that = this;
+          function keypressHandler(evt) {
+            if (evt.keyCode === keys.ENTER) {


Problem on login:

Type the username

Type the password

Hit enter

The login failed because the password wasn't set properly:

[1, "performLogin", 1, 0, {1: {str: "Username:Password"}, 2: {str: "test:"}}]

csordasmarton · 2018-01-29T13:33:59Z

www/login.html

+  <link type="text/css" rel="stylesheet" href="scripts/plugins/dojo/dijit/themes/claro/claro.css" />
+  <link type="text/css" rel="stylesheet" href="style/codecheckerviewer.css" />
+  <link type="text/css" rel="stylesheet" href="style/login.css" />
+  <link type="text/css" rel="stylesheet" href="style/productlist.css" />


Why does the login use the productlist css?

The styles for formElement and form-input are defined in the productlist.css file.

whisperity added enhancement 🌟 RDY-OnHold 🛑 Patch reviewed and ready, but don't merge due to having to merge a dependent patch first. GUI 🎨 labels Jan 17, 2018

whisperity requested review from csordasmarton and gyorb January 17, 2018 15:56

whisperity force-pushed the login-window branch from 84d3dc9 to 72c19ea Compare January 18, 2018 10:08

whisperity removed the RDY-OnHold 🛑 Patch reviewed and ready, but don't merge due to having to merge a dependent patch first. label Jan 18, 2018

csordasmarton suggested changes Jan 18, 2018

View reviewed changes

whisperity force-pushed the login-window branch from 72c19ea to d01d8eb Compare January 18, 2018 11:32

whisperity requested a review from csordasmarton January 18, 2018 11:32

Refactor to early returns as much as possible in the do_GET logic

6cd1241

whisperity force-pushed the login-window branch from d01d8eb to d3b7c7c Compare January 23, 2018 16:03

csordasmarton suggested changes Jan 29, 2018

View reviewed changes

whisperity force-pushed the login-window branch from d3b7c7c to b15a7dd Compare January 29, 2018 14:05

Add a login form and a logout button to the WebGUI

ae3405d

whisperity force-pushed the login-window branch from b15a7dd to ae3405d Compare January 31, 2018 08:29

whisperity requested a review from csordasmarton January 31, 2018 08:30

csordasmarton approved these changes Feb 2, 2018

View reviewed changes

gyorb merged commit 575c68e into Ericsson:master Feb 5, 2018

whisperity mentioned this pull request Feb 6, 2018

Remove soft session lifetime completely #1344

Merged

whisperity deleted the login-window branch January 24, 2019 09:53

whisperity mentioned this pull request Apr 26, 2020

Implement requiring authentication to access a server Ericsson/CodeCompass#386

Merged


		product_endpoint, path = routing.split_client_GET_request(self.path)

		if self.server.manager.isEnabled() and not auth_session \

Conversation

whisperity commented Jan 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

csordasmarton commented Jan 18, 2018

Uh oh!

whisperity commented Jan 23, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

whisperity commented Jan 17, 2018 •

edited

Loading