Skip to content

fix: reduce MSRV to 1.70 and add CI #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EricLBuehler merged 6 commits into from
Aug 9, 2025
Merged

fix: reduce MSRV to 1.70 and add CI #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6dbb810
fix: reduce MSRV to 1.70 and add CI
LDeakin Jun 18, 2025
414b9ab
Merge remote-tracking branch 'upstream/master' into msrv_1.70
LDeakin Aug 9, 2025
f079fa4
fix: `unnecessary_transmutes` lint false-positive
LDeakin Aug 9, 2025
aabcfa8
fix: Rust 1.70 in ci
LDeakin Aug 9, 2025
2704481
fix: downgrade half in the lock file to the minimum version
LDeakin Aug 9, 2025
f6b48a6
fix: allow unknown_lints for unnecessary_transmutes with Rust 1.70
LDeakin Aug 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macOS-latest]
rust: [stable]
rust: [stable, "1.70"]
steps:
- uses: actions/checkout@v2
- uses: actions-rs/toolchain@v1
Expand Down
45 changes: 35 additions & 10 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
[package]
name = "float8"
version = "0.4.0"
rust-version = "1.70"
edition = "2021"
description = "8-bit floating point types for Rust"
homepage = "https://github.com/EricLBuehler/float8"
Expand Down
4 changes: 3 additions & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,9 @@ enum SaturationType {

// https://gitlab.com/nvidia/headers/cuda-individual/cudart/-/blob/main/cuda_fp8.hpp?ref_type=heads#L97
const fn convert_to_fp8(x: f64, saturate: SaturationType, fp8_interpretation: Kind) -> u8 {
let xbits: u64 = x.to_bits();
// TODO: use x.to_bits() with MSRV 1.83
#[allow(unknown_lints, unnecessary_transmutes)]
let xbits: u64 = unsafe { std::mem::transmute::<f64, u64>(x) };

let (
fp8_maxnorm,
Expand Down
Loading