reimplemented on latest upstream (August 11th, 2024)#162
Merged
Conversation
Merged
82ee585 to
02d8763
Compare
|
My test with rsmpi passes with this (bumping the Enzyme commit). What happened to the EnzymeAD/rustbook test suite? I see no checks in this PR nor references to that repo, but I don't want to lose that (even if it will have to be done differently to go upstream). |
Collaborator
Author
|
Awesome. I'll bump Enzyme, clean this up a bit and make upstream PRs. |
|
Can you post the manual procedure you're using somewhere so it doesn't get lost? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully a base to discuss upstreaming :)