Conversation
Added tests to `tests/unit/test_async/test_generator.py` to cover: - Generator correctly closing when an exception is raised inside the context manager - Exception propagation when the generator itself raises an error - Proper handling of positional and keyword arguments passed to the wrapped generator Co-authored-by: rnovatorov <20299819+rnovatorov@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: The testing gap in
src/enapter/async_/generator.pyaddressed by adding missing test cases to verify generator cleanup and exception propagation inside an async context.📊 Coverage: Scenarios now tested include exceptions within the
async withblock closing the generator via thefinallyblock, exceptions correctly propagating from the generator itself, and ensuring arguments/kwargs are passed securely to the generator.✨ Result: Test suite coverage for
enapter.async_.generatorremains at 100%, but is now fully comprehensive and catches realistic failure modes and correct argument passing. Tested cleanly underpytestwith no regressions across thetests/unitcodebase.PR created automatically by Jules for task 9721216632657680690 started by @rnovatorov