Prepare 23.3.3rc1#1534
Merged
Merged
Conversation
In CreatePeginWitnessInner, the MerkleBlock is always serialized without witness: PROTOCOL_VERSION | SERIALIZE_TRANSACTION_NO_WITNESS In DecomposePeginWitness before this change, the MerkleBlock was deserialized with witness: PROTOCOL_VERSION This was only noticed as an issue in the pegin subsidy implementation, in a failure in the feature_dynafed functional test. In the test_transition_mempool_eject test case, the Merkle block proof is coming from the same chain where we are creating a pegin. See the comment: "hack: since we're not validating peg-ins in parent chain, just make both the funding and claim tx on same chain (printing money)" I haven't investigated enough to explain why this causes a deserialization failure in this specific case, but presumably this change is correct since we're always serializing without witness. Before this DecomposePeginWitness was only used in src/psbt.cpp
…chain peg-in subsidy and minimum peg-in amount a18a88b grammar: prefer peg-in to pegin in messages (Byron Hambly) 90b2b3b test: add pegin subsidy functional test (Byron Hambly) 186bb25 validation: check for peg-in subsidy and minimum (Byron Hambly) 51c89c6 subsidy: implementation for claimpegin, createrawpegin, and RPCs (Byron Hambly) 94cde59 subsidy: add chainparams and init (Byron Hambly) f3b63f4 DecomposePeginWitness: fix deserialization flags for MerkleBlock proof (Byron Hambly) Pull request description: Implementation for [ELIP 202](https://github.com/ElementsProject/ELIPs/blob/main/elip-0202.mediawiki) ACKs for top commit: jsarenik: Running ACK a18a88b tomt1664: Tested ACK a18a88b Tree-SHA512: 984fe2aa32e6814e14c9535e9fea7e03d3b6cf7a35621ccfb2a081a6ebab01906c5e883c5b505ced53f254401d30b6e975cb05e88efc8d3fbedc79abd0be72a2
tomt1664
approved these changes
Feb 18, 2026
Member
|
Tested ACK 6c45fa0 |
Member
|
ACK 6c45fa0; diff looks as expected, built and tested locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates master to 7791d31 which ELIP 202 and bumps version/manpages