ElectronNET.Host: Replace website by a real ts project#935
Merged
FlorianRappl merged 2 commits intoElectronNET:developfrom Nov 15, 2025
Merged
ElectronNET.Host: Replace website by a real ts project#935FlorianRappl merged 2 commits intoElectronNET:developfrom
FlorianRappl merged 2 commits intoElectronNET:developfrom
Conversation
(it's sufficient on save)
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request migrates the ElectronNET.Host project from a legacy ASP.NET website project to a modern TypeScript project using the Microsoft.VisualStudio.JavaScript.Sdk. This is the final step in modernizing the ElectronNET infrastructure.
Key changes:
- Replaces the legacy website project format with an
.esprojJavaScript SDK project - Updates TypeScript configuration with modern module resolution and compiler options
- Adds proper type declarations and ambient module definitions for better IDE support
Reviewed Changes
Copilot reviewed 11 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| ElectronNET.sln | Replaces old website project with new .esproj JavaScript SDK project; updates Visual Studio version and project dependencies |
| ElectronNET.WebApp.csproj | Adds TypeScript compilation configuration properties |
| ElectronNET.Host/tsconfig.json | Modernizes TypeScript configuration with updated compiler options and module resolution |
| ElectronNET.Host/package.json | Updates ESLint version and reorganizes dependencies; adds build and clean scripts |
| ElectronNET.Host/package-lock.json | Updates all package dependencies with new versions and license information |
| ElectronNET.Host/types-shims.d.ts | Adds ambient type declarations for external modules to silence TypeScript errors |
| ElectronNET.Host/globals.d.ts | Adds ambient declarations for global variables to improve type safety |
| ElectronNET.Host/eslint.config.js | Adds ESLint configuration file (placeholder) |
| ElectronNET.Host/api/ipc.js | Refactors to use optional chaining operator for cleaner code |
| ElectronNET.Host/ElectronNET.Host.esproj | New JavaScript SDK project file |
| ElectronNET.Host/.vscode/launch.json | Updates debug configuration with improved settings |
| ElectronNET.Host/ElectronHostHook/*.js | Regenerated JavaScript files with updated source maps and module imports |
Files not reviewed (1)
- src/ElectronNET.Host/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That's the last one 😉