Skip to content

Use common authentication modes for tenant validation - #894

Merged
nevil-mathew merged 1 commit into
ELEVATE-Project:developfrom
Vinod-V3:login-enhancement
Jul 15, 2026
Merged

Use common authentication modes for tenant validation#894
nevil-mathew merged 1 commit into
ELEVATE-Project:developfrom
Vinod-V3:login-enhancement

Conversation

@Vinod-V3

@Vinod-V3 Vinod-V3 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved tenant configuration validation to correctly accept all supported authentication modes.
    • Preserved validation requirements for non-empty authentication mode lists and boolean auto-registration settings.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Tenant configuration validation now sources allowed authentication modes from common.AUTH_MODES rather than the default tenant configuration.

Changes

Tenant configuration validation

Layer / File(s) Summary
Shared authentication mode validation
src/validators/v1/tenant.js
allowedAuthModes is derived from Object.values(common.AUTH_MODES), while array, membership, and boolean validation rules remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Poem

A bunny checks each mode in line,
From shared constants, neat and fine.
OTP and passwords hop aboard,
Tenant rules stay safely stored.
One small change, validation bright—
The burrow’s config now feels right!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly matches the main change: tenant validation now uses common authentication modes.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot changed the title @coderabbit ai Use common authentication modes for tenant validation ai Jul 15, 2026
@Vinod-V3 Vinod-V3 changed the title Use common authentication modes for tenant validation ai Use common authentication modes for tenant validation Jul 15, 2026
@nevil-mathew
nevil-mathew merged commit eb1d469 into ELEVATE-Project:develop Jul 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants