add: linux/arm/v7 to build platforms#843
Conversation
WalkthroughThe workflow for building Docker images was updated to include linux/arm/v7 in the multi-platform build matrix alongside linux/amd64 and linux/arm64. No other steps, logic, or control flow were modified. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| tags: ${{ steps.meta.outputs.tags }} | ||
| labels: ${{ steps.meta.outputs.labels }} | ||
| platforms: linux/amd64,linux/arm64 | ||
| platforms: linux/amd64,linux/arm64,linux/arm/v7 |
There was a problem hiding this comment.
Add QEMU emulation before building for linux/arm/v7.
Expanding to linux/arm/v7 needs binfmt support. Unlike amd64/arm64, GitHub-hosted runners don’t have 32-bit ARM emulation preloaded, so BuildKit will fail when it tries to execute RUN layers for that architecture. Please add a docker/setup-qemu-action@v3 step (with platforms: arm,arm64) before invoking Buildx so the new target can actually build.
🤖 Prompt for AI Agents
.github/workflows/docker-image.yml around line 80: adding linux/arm/v7 requires
QEMU binfmt registration on GitHub runners; insert a docker/setup-qemu-action@v3
step (configure with platforms: arm,arm64) before the Buildx/build steps so QEMU
emulation is registered, then proceed to the existing buildx setup and build
with platforms: linux/amd64,linux/arm64,linux/arm/v7.
Summary by CodeRabbit