kafka-topic-fixed

[MallanagoudaB]

Summary by CodeRabbit

• Bug Fixes

  • Corrected service health check configuration by associating the message topic with Kafka checks and removing it from Redis checks. This ensures accurate monitoring and reduces false positives in system status.

• Chores

  • Streamlined health check settings to align with current infrastructure, improving reliability and consistency across environments without altering existing defaults or workflows.

[coderabbitai]

Walkthrough

Moved the topic property from the Redis health check configuration to the Kafka health check configuration in src/health-checks/health.config.js. No other structural changes.

Changes

Cohort / File(s)	Summary of Changes
Health check config src/health-checks/health.config.js	Added kafka.topic = process.env.KAFKA_HEALTH_CHECK_TOPIC; removed redis.topic; no other defaults changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• kafka-topic-added #800 — Also modifies the health check topic configuration but assigns it to Redis; this PR moves it to Kafka, indicating a related configuration alignment.

Poem

I twitch my ears at configs neat,
Kafka gets the topic seat,
Redis sheds a tiny load,
Health checks hop on the proper road.
Thump-thump—deploy complete! 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch KafkaTopic

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/health-checks/health.config.js (1)

12-16: Auto-disable Kafka health check when brokers/topic are unset.

Prevents false negatives in local/test envs and avoids producing to an undefined topic.

Apply:

 		kafka: {
-			enabled: true,
+			enabled: Boolean(process.env.KAFKA_URL && process.env.KAFKA_HEALTH_CHECK_TOPIC),
 			url: process.env.KAFKA_URL,
 			topic: process.env.KAFKA_HEALTH_CHECK_TOPIC,
 		},

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 94f9aea and 963c8bc.

📒 Files selected for processing (1)

• src/health-checks/health.config.js (1 hunks)

🔇 Additional comments (1)

src/health-checks/health.config.js (1)

15-15: Kafka health check topic wiring ✅

• KAFKA_HEALTH_CHECK_TOPIC is declared in src/envVariables.js (lines 413–416) with a default value.
• It’s used in src/health-checks/health.config.js (line 15) as intended.
• No residual redis.topic references remain.

LGTM—approving these changes.