Licenses for EESSI#457
Conversation
|
Instance
|
|
Now the add_license_info.py script can process pypi, github and manual license addition to licenses.json file. There is also included work for other license fonts (libraries.io, repology and CRAN). This is fully functional, ready for review. |
Updates by the bot instance
|
|
Waiting for review/approval |
Updates by the bot instance
|
As suggested in 02/04/2023 meeting. Previously, spdx argument has been used to manually feeded licenses.
ocaisa
left a comment
ocaisa
left a comment
There was a problem hiding this comment.
I wonder if we shouldn't break this off into it's own repository and create a GitHub Action for it? If we do it like then it can be easily used by others, and in other repositories for EasyStack files.
| print('project in licenses.json') | ||
| else: | ||
| print('we do not have the license, adding into licenses.json') | ||
| licenses[project]=dict(info) |
There was a problem hiding this comment.
From what I can see, this doesn't store information for the case of a licence change or multiple licences (academic versus commercial).
| else: | ||
| print('we do not have the license, adding into licenses.json') | ||
| licenses[project]=dict(info) | ||
| licJson=json.dumps(licenses, indent=4) |
There was a problem hiding this comment.
Perhaps we should give 2 options here. There's kind of an assumption that this will make a change but if this is called within a GitHub Action the update to the licences file will be lost (without giving the Action permissions to write to the PR). It would be good to allow the display of the information in patch format so that it can be copied from the GitHub Actions and applied (or even posted as a review).
|
PR merged! Moved |
1 similar comment
|
PR merged! Moved |
|
PR merged! Moved |
|
PR merged! Moved |
|
Covered by Mr 675 |
3 participants
WIP