Fix commit failures with empty messages and "nothing to commit"#230
Merged
Merged
Conversation
1. With "Use GUI functions" on but TortoiseGit not detected, commits ran with an empty message: auto-commits failed silently and manual commits failed with "Aborting commit due to empty commit message". Project Explorer now prompts with its Commit Message dialog when no GUI client is available (new lGUIAvailable property). 2. git's "nothing to commit" response and hg's "nothing changed" exit code are now treated as success instead of showing a spurious "The commit failed" error (e.g. after a build that changed no text equivalents). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
bobloy
force-pushed
the
fix/commit-message-handling
branch
from
ed84d31 to
bbd81ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two version control commit bugs:
1. Empty commit messages when "Use GUI functions" is on but TortoiseGit isn't detected. Project Explorer skipped its Commit Message dialog, expecting TortoiseGit to prompt, but then fell back to command-line git — so auto-commits failed silently and manual commits failed with "Aborting commit due to empty commit message". Commits now only rely on a GUI client for the message when one is actually available (new
lGUIAvailableproperty onVersionControlOperations); otherwise the Commit Message dialog prompts. Mercurial, which has no GUI commit support, gets the same treatment.2. "Nothing to commit" treated as a failed commit. Committing when nothing changed (e.g. auto-commit after a build that changed no text equivalents) showed a spurious "The commit failed" error. git's "nothing to commit" responses and hg's "nothing changed" exit code are now treated as success. Also: command-line git errors are no longer swallowed when TortoiseGit is installed but the GUI option is off, and the failure dialog now labels the displayed text as the provider's response rather than as the commit message.
Includes regenerated binaries (FoxBin2PRG).
🤖 Generated with Claude Code