Skip to content

Conversation

@gnapse
Copy link
Contributor

@gnapse gnapse commented Jul 12, 2022

Short description

These 3 components are no longer used in either Todoist or Twist, so I'm taking the opportunity that we'll have a breaking change release soon (see #671) to remove them entirely.

Test plan

  • Double-check that Todoist and Twist codebase do not use any of these components.

    For the two with the word "deprecated" in their names, it is straightforward.

    For Checkbox is trickier, but make sure to search in the entire codebase that name with case-sensitive search and the exact word. Then exclude the test files, cypress, i18n files, to get less false positives. You should be left with a relatively small number of hits that you can then validate are non from importing from Reactist.

PR Checklist

  • Added tests for bugs / new features
  • Updated docs (storybooks, readme)
  • Executed npm run validate and made sure no errors / warnings were shown
  • Described changes in CHANGELOG.md
  • Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
  • Updated all static build artifacts (npm run build-all)

Versioning

New major release.

@gnapse gnapse requested a review from a team July 12, 2022 12:26
@gnapse gnapse self-assigned this Jul 12, 2022
@gnapse gnapse requested review from jvalente and removed request for a team July 12, 2022 12:26
@frankieyan frankieyan force-pushed the ernesto/remove-deprecated-components branch from ea1900f to 92639c4 Compare August 12, 2022 16:15
@frankieyan frankieyan mentioned this pull request Aug 12, 2022
@frankieyan frankieyan force-pushed the ernesto/remove-deprecated-components branch from 92639c4 to 1b9f12b Compare August 15, 2022 14:25
@frankieyan frankieyan merged commit 3a182c0 into main Aug 15, 2022
@frankieyan frankieyan deleted the ernesto/remove-deprecated-components branch August 15, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants