Skip to content

refactor: match more links on opensea#6351

Merged
guanbinrui merged 3 commits into
developfrom
refactor/opensea-url-matcher
May 26, 2022
Merged

refactor: match more links on opensea#6351
guanbinrui merged 3 commits into
developfrom
refactor/opensea-url-matcher

Conversation

@guanbinrui

@guanbinrui guanbinrui commented May 26, 2022

Copy link
Copy Markdown
Member

Description

Update the OpenSea link pattern for more links.

Closes # (NO_ISSUE)

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

@guanbinrui
guanbinrui marked this pull request as ready for review May 26, 2022 04:23
@github-actions

github-actions Bot commented May 26, 2022

Copy link
Copy Markdown
Contributor

@github-actions
github-actions Bot temporarily deployed to pull request May 26, 2022 04:25 Inactive
UncleBill
UncleBill previously approved these changes May 26, 2022
Comment thread packages/mask/src/plugins/Collectible/constants.ts Outdated
@github-actions
github-actions Bot temporarily deployed to pull request May 26, 2022 04:51 Inactive
hanszhoou
hanszhoou previously approved these changes May 26, 2022
Comment thread packages/mask/src/plugins/Collectible/constants.ts Outdated
@github-actions
github-actions Bot temporarily deployed to pull request May 26, 2022 05:08 Inactive
@AinuX

AinuX commented May 26, 2022

Copy link
Copy Markdown
Collaborator

Checked

@guanbinrui
guanbinrui merged commit c5e0ae3 into develop May 26, 2022
@guanbinrui
guanbinrui deleted the refactor/opensea-url-matcher branch May 26, 2022 07:03
guanbinrui added a commit that referenced this pull request May 26, 2022
* refactor: match more links on opensea

* fix: the wrong group index

* refactor: remove matic
@Lanttcat Lanttcat mentioned this pull request Jun 2, 2022
13 tasks
guanbinrui added a commit that referenced this pull request Jun 7, 2022
* refactor: match more links on opensea

* fix: the wrong group index

* refactor: remove matic
guanbinrui added a commit that referenced this pull request Jun 7, 2022
* fix: kill no connect when no localkey (#6352)

* hotfix: some ui issues (#6354)

* fix: kill no connect when no localkey

* fix: some ui issues

* fix: build err

* refactor: match more links on opensea (#6351)

* refactor: match more links on opensea

* fix: the wrong group index

* refactor: remove matic

* fix: collectible loading icon position (#6353)

* fix: opensea parse && asset player loading icon position

* chore: duplicate

Co-authored-by: BillyS <Billy@mask.io>
Co-authored-by: Hancheng Zhou <z308114274@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants