Skip to content
This repository was archived by the owner on Feb 17, 2026. It is now read-only.

Improve minimap camera controls#642

Merged
Indy2222 merged 3 commits intoDigitalExtinction:mainfrom
Zakru:feature/minimap-improvements
Sep 7, 2023
Merged

Improve minimap camera controls#642
Indy2222 merged 3 commits intoDigitalExtinction:mainfrom
Zakru:feature/minimap-improvements

Conversation

@Zakru
Copy link
Contributor

@Zakru Zakru commented Jul 24, 2023

  • Minimap no longer registers camera input when mouse is pressed down elsewhere and brought over the minimap
  • Minimap camera responds to press instead of release
  • Camera can now be dragged across the minimap in addition to clicking

I felt that at least with the current system, these new camera controls don't fit the existing event model, so I separated them to handle raw mouse input.

@Zakru Zakru force-pushed the feature/minimap-improvements branch from 7adbac3 to 56f67c4 Compare July 27, 2023 20:08
Copy link
Collaborator

@Indy2222 Indy2222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left multiple comments, but nothing major.

@Zakru Zakru force-pushed the feature/minimap-improvements branch from 56f67c4 to 4ac876e Compare September 3, 2023 23:14
Copy link
Collaborator

@Indy2222 Indy2222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor note, otherwise LGTM.

@Zakru
Copy link
Contributor Author

Zakru commented Sep 7, 2023

Opened #715 based on release event issues

@Indy2222 Indy2222 merged commit 0202976 into DigitalExtinction:main Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants