Skip to content

Added conditions for branched services#214

Open
adedamola-sode wants to merge 4 commits into
mainfrom
multiple-beamlines-one-service
Open

Added conditions for branched services#214
adedamola-sode wants to merge 4 commits into
mainfrom
multiple-beamlines-one-service

Conversation

@adedamola-sode

@adedamola-sode adedamola-sode commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

Added support for multiple synoptic beamlines.

  • Added conditional in find-dirs in main.py to handle branches whose naming in the techui.yaml start with j/k
  • Changed synoptic_dir to be abs_path.parent

@codecov

codecov Bot commented Apr 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.27%. Comparing base (bcf6738) to head (3dfa638).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
+ Coverage   96.25%   96.27%   +0.01%     
==========================================
  Files          13       13              
  Lines         962      966       +4     
==========================================
+ Hits          926      930       +4     
  Misses         36       36              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/techui_builder/__main__.py Outdated
Comment thread src/techui_builder/__main__.py Outdated
@OCopping

OCopping commented May 5, 2026

Copy link
Copy Markdown
Collaborator

Are you able to add a test-case for this new logic please?

@adedamola-sode adedamola-sode force-pushed the multiple-beamlines-one-service branch from 274a7e9 to 927faba Compare May 8, 2026 06:47
@niamhdougan

Copy link
Copy Markdown
Collaborator

Please could you add some info of how branched beamlines should be structured moving forward? e.g. BL15I-synoptic and BL15J-synoptic or does everything get put inside synoptic etc?

@adedamola-sode

adedamola-sode commented May 21, 2026

Copy link
Copy Markdown
Collaborator Author

@niamhdougan , sorry, I am just now seeing this.

Basically, I based it off the current i15-services repository. Currently, in i15-services, there exists a services directory where the services could either be bl15j, or bl15i. So I have based the screen generation and validation on the difference in the synoptic directory, where the techui.yaml file, could either be a bl15i, or bl15j, or k yaml ( it's contents i.e, beamline, location, e.t.c.) file. Based off what the techui-yaml file says, it looks for the corresponding services in the services folder.

So basically, there will be one i15-services, but for each branch beamline, there will be seperate techui.yaml files. It will be named synoptic but the techui.yaml file will change, we can also keep multiple techui.yaml files in the same synoptic directory, as we reference the chosen one when building the screens.

EDIT: Since the top level index.bob will live in the synoptic folder, causing duplicates/overwriting for multiple techui.yamls in one synoptic folder, the synoptic folder will have to be slit for synoptic-i, synoptic-j etc.

@adedamola-sode adedamola-sode force-pushed the multiple-beamlines-one-service branch 2 times, most recently from 7ac9eac to 7e184c7 Compare May 26, 2026 14:34
@adedamola-sode

Copy link
Copy Markdown
Collaborator Author

If there's a synoptic-i, and then a synoptic-j... We will end up duplicating the techui-support folder, I propose for branched beamlines like this, the techui-support folder is symlinked

@adedamola-sode adedamola-sode force-pushed the multiple-beamlines-one-service branch from 07b14d3 to e1aaf69 Compare May 28, 2026 08:05
@adedamola-sode adedamola-sode marked this pull request as ready for review May 28, 2026 10:35
@adedamola-sode adedamola-sode requested a review from OCopping May 28, 2026 10:36
@adedamola-sode adedamola-sode force-pushed the multiple-beamlines-one-service branch from 6cc2f62 to 742fec6 Compare June 2, 2026 08:24
@adedamola-sode adedamola-sode force-pushed the multiple-beamlines-one-service branch from 742fec6 to 3dfa638 Compare June 16, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants