Skip to content

chore: Set default log file to empty string#28

Merged
JamieSinn merged 4 commits into
mainfrom
jamie/default-log-file
Oct 7, 2024
Merged

chore: Set default log file to empty string#28
JamieSinn merged 4 commits into
mainfrom
jamie/default-log-file

Conversation

@JamieSinn

Copy link
Copy Markdown
Member

No description provided.

@JamieSinn
JamieSinn requested review from a team and kaushalkapasi October 4, 2024 16:47
@JamieSinn JamieSinn changed the title Set default log file to empty string chore: Set default log file to empty string Oct 4, 2024
@JamieSinn
JamieSinn merged commit 99df470 into main Oct 7, 2024
@JamieSinn
JamieSinn deleted the jamie/default-log-file branch October 7, 2024 15:29
jonathannorris added a commit that referenced this pull request Jul 20, 2026
* chore: resolve open dependabot security alerts

- golang.org/x/crypto v0.45.0 -> v0.54.0 (critical/high/medium, alerts #21 #24 #25 #27 #29 #30 #32 #31 #28 #26 #22)
- golang.org/x/net v0.47.0 -> v0.57.0 (medium, alert #20)
- golang.org/x/sys v0.38.0 -> v0.47.0 (transitive)
- golang.org/x/text v0.31.0 -> v0.40.0 (transitive)

* fix: update toolchain to Go 1.25 and fix golangci-lint v2 compatibility

- Upgrade Dockerfile base image golang:1.24 -> golang:1.25 (required by go.mod go 1.25.0 directive)
- Update golangci-lint-action v3 -> v8 to support Go 1.25+ (v1.64.8 was built with Go 1.24)
- Remove --sort-results flag (removed in golangci-lint v2)
- Add //nolint:errcheck to defer X.Close() patterns (v2 reports these; v1 excluded by default)
- Lowercase error string in options.go to fix ST1005
- Discard return value of pretty.Println in test to fix errcheck
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants