fix: exclude context lines from git diff#247
Closed
maxnowack wants to merge 1 commit into
Closed
Conversation
Contributor
|
Hey @maxnowack, we rely on the context lines to help us find matches. For example, if a call to the variable method was split across multiple lines and only one was modified, we'd still consider that a change. For the case where the variable call wasn't changed at all, I'm testing with this diff and seeing the expected output, can you provide more details or a code snippet for the case you're describing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there are more than 0 lines of context returned by `git diff', the CLI will also detect these context lines as changes, even though these lines have not been modified.
I noticed this bug while using the feature-flag-pr-insights-action. Some pull requests were commented by the action with variable changes (added and removed at the same time, but that is another issue), but the variables were not touched in the PR.