Skip to content

fix features get returning empty array when no keys #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elliotCamblor merged 1 commit into from
Aug 2, 2023
Merged

fix features get returning empty array when no keys #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ $ npm install -g @devcycle/cli
$ dvc COMMAND
running command...
$ dvc (--version)
@devcycle/cli/5.2.0 linux-x64 node-v18.16.0
@devcycle/cli/5.2.0 darwin-arm64 node-v18.16.0
$ dvc --help [COMMAND]
USAGE
$ dvc COMMAND
Expand Down
2 changes: 1 addition & 1 deletion oclif.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "5.1.0",
"version": "5.2.0",
"commands": {
"authCommand": {
"id": "authCommand",
Expand Down
4 changes: 2 additions & 2 deletions src/commands/features/get.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ export default class DetailedFeatures extends Base {

public async run(): Promise<void> {
const { flags } = await this.parse(DetailedFeatures)
const keys = flags['keys']?.split(',') || []
const keys = flags['keys']?.split(',')
const { project, headless } = flags
await this.requireProject(project, headless)
let features
if (keys) {
features = await batchRequests(
keys,
keys,
(key) => fetchFeatureByKey(this.authToken, this.projectKey, key)
)
} else {
Expand Down