feat(learning): pedagogical validation feedback with pass/fail/error states#64
Merged
Merged
Conversation
Derssa
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The roadmap player previously rendered validation results raw (
[pass]/[fail]text, validator type slugs, raw error codes). This PR turns them into real pedagogical feedback:Expected/Observedvalues in monospace.stepOutcomehelper: an infra error never shows as a learner failure. Error wins over fail in the aggregate because the step's real state is unknowable when a check couldn't run (documented invalidationStatus.ts).features/learning/validationStatus.ts; icons carryrole="img"+aria-labelso status is announced by screen readers.--color-warning*CSS variables aligned with the existing amber infrastructure-error language (daemon banner, node badge, toast).No backend changes; no changes to
useLearningPlayer(revalidation already replaces the whole per-step response, so no stale artifacts by construction).Types of Changes
Verification & Testing
Automated Checks
npm run lintsuccessfully with no errorsnpm run buildsuccessfully with no compilation errorsnpm testsuccessfully (all tests pass)Manual Verification
Drove the full flow in a real browser (Playwright + Chrome) against real Docker on the example roadmap:
webcontainer, revalidated → green banner + Next step button, no artifacts from the failed attempt; CTA advances to step 2.Frontend suite: 203 tests green (8 new: three result families, aggregation precedence, fully-validated step, revalidation without artifacts, Next step CTA).
Checklist