Fixed Notification System - #60
Merged
Merged
Conversation
|
@chiscookeke11 is attempting to deploy a commit to the pjmq2's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pablomadrigal
approved these changes
Apr 7, 2025
pablomadrigal
left a comment
Contributor
There was a problem hiding this comment.
Great work, thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #45
Description:
This PR fixes the notification system to ensure that notifications are properly displayed across the application. The previous implementation had issues with inconsistent rendering of toast notifications.
Changes Made:
ToastProviderto ensure it properly wraps the app and provides notifications globally.RootLayoutto integrateToastProvidercorrectly within the application tree.Toastcomponent with improved styles and functionality, ensuring proper placement and visibility.default,destructive, andsuccess) for better UI consistency.Toastercalls in various components with the newToastProviderimplementation.Implementation Details:
How to Test:
Screenshots (If Applicable):
https://www.loom.com/share/7594e0db34984130a31003a8ff1050d1?sid=7a828bcf-f4d0-4a60-90ba-46706711e3de
Checklist:
✅ Fixes notification visibility issues.
✅ Implements a consistent and reusable toast system.
✅ Refactors layout to avoid redundant
Toasterinstances.✅ Improves UI and accessibility.