Skip to content

Fixed Notification System - #60

Merged
pablomadrigal merged 2 commits into
DeVoteStark:mainfrom
chiscookeke11:issue-#45
Apr 7, 2025
Merged

Fixed Notification System #60
pablomadrigal merged 2 commits into
DeVoteStark:mainfrom
chiscookeke11:issue-#45

Conversation

@chiscookeke11

Copy link
Copy Markdown
Contributor

closes: #45

Description:

This PR fixes the notification system to ensure that notifications are properly displayed across the application. The previous implementation had issues with inconsistent rendering of toast notifications.

Changes Made:

  • Refactored the ToastProvider to ensure it properly wraps the app and provides notifications globally.
  • Updated RootLayout to integrate ToastProvider correctly within the application tree.
  • Added a new Toast component with improved styles and functionality, ensuring proper placement and visibility.
  • Standardized toast variants (default, destructive, and success) for better UI consistency.
  • Replaced redundant Toaster calls in various components with the new ToastProvider implementation.

Implementation Details:

  • Leveraged Radix UI Toast primitives for better flexibility.
  • Ensured accessibility improvements for screen readers.
  • Used Tailwind classes to improve responsiveness and UI consistency.
  • Fixed notification stacking issues to prevent overlap or missing toasts.

How to Test:

  1. Pull this branch and start the dev server.
  2. Trigger notifications in different scenarios (e.g., success, error, warning).
  3. Ensure that:
    • Notifications appear consistently.
    • The styles match the expected design.
    • Notifications auto-dismiss correctly.
    • Close button works as expected.

Screenshots (If Applicable):

https://www.loom.com/share/7594e0db34984130a31003a8ff1050d1?sid=7a828bcf-f4d0-4a60-90ba-46706711e3de


Checklist:

✅ Fixes notification visibility issues.
✅ Implements a consistent and reusable toast system.
✅ Refactors layout to avoid redundant Toaster instances.
✅ Improves UI and accessibility.


@vercel

vercel Bot commented Apr 4, 2025

Copy link
Copy Markdown

@chiscookeke11 is attempting to deploy a commit to the pjmq2's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel

vercel Bot commented Apr 7, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devote ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 0:02am

@pablomadrigal pablomadrigal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you

@pablomadrigal
pablomadrigal merged commit 7f1c16f into DeVoteStark:main Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Notification System - Ensure Notifications Are Displayed Correctly

2 participants