chore(tracer): contrib checking for patch.py and patch.pyc#17196
Conversation
Codeowners resolved as |
Performance SLOsComparing candidate brettlangdon/monkey.pyc (6feb1af) with baseline main (97d4f14) 🟡 Near SLO Breach (3 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 19.600ms (SLO: <22.300ms 📉 -12.1%) vs baseline: -0.4% Memory: ✅ 69.333MB (SLO: <73.500MB -5.7%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.322ms (SLO: <1.450ms -8.8%) vs baseline: -0.2% Memory: ✅ 67.539MB (SLO: <71.500MB -5.5%) vs baseline: +4.8% ✅ iastTime: ✅ 19.690ms (SLO: <22.250ms 📉 -11.5%) vs baseline: -0.3% Memory: ✅ 69.335MB (SLO: <75.000MB -7.6%) vs baseline: +5.0% ✅ profilerTime: ✅ 15.126ms (SLO: <16.550ms -8.6%) vs baseline: +0.3% Memory: ✅ 60.438MB (SLO: <61.000MB 🟡 -0.9%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 19.570ms (SLO: <21.750ms 📉 -10.0%) vs baseline: -0.5% Memory: ✅ 69.298MB (SLO: <73.500MB -5.7%) vs baseline: +4.8% ✅ span-code-originTime: ✅ 20.211ms (SLO: <28.200ms 📉 -28.3%) vs baseline: +1.5% Memory: ✅ 69.657MB (SLO: <75.000MB -7.1%) vs baseline: +5.0% ✅ tracerTime: ✅ 19.680ms (SLO: <21.750ms -9.5%) vs baseline: +0.3% Memory: ✅ 69.323MB (SLO: <75.000MB -7.6%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 21.090ms (SLO: <23.500ms 📉 -10.3%) vs baseline: +0.2% Memory: ✅ 71.327MB (SLO: <75.000MB -4.9%) vs baseline: +4.9% ✅ tracer-dont-create-db-spansTime: ✅ 19.789ms (SLO: <21.500ms -8.0%) vs baseline: ~same Memory: ✅ 69.327MB (SLO: <75.000MB -7.6%) vs baseline: +5.0% ✅ tracer-minimalTime: ✅ 16.864ms (SLO: <17.500ms -3.6%) vs baseline: ~same Memory: ✅ 69.297MB (SLO: <75.000MB -7.6%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 19.610ms (SLO: <21.750ms -9.8%) vs baseline: ~same Memory: ✅ 69.206MB (SLO: <72.500MB -4.5%) vs baseline: +4.6% ✅ tracer-no-cachesTime: ✅ 17.610ms (SLO: <19.650ms 📉 -10.4%) vs baseline: -0.1% Memory: ✅ 69.356MB (SLO: <75.000MB -7.5%) vs baseline: +5.1% ✅ tracer-no-databasesTime: ✅ 19.369ms (SLO: <20.100ms -3.6%) vs baseline: ~same Memory: ✅ 69.359MB (SLO: <75.000MB -7.5%) vs baseline: +4.9% ✅ tracer-no-middlewareTime: ✅ 19.391ms (SLO: <21.500ms -9.8%) vs baseline: -0.3% Memory: ✅ 69.259MB (SLO: <75.000MB -7.7%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 19.855ms (SLO: <22.000ms -9.8%) vs baseline: +1.1% Memory: ✅ 69.320MB (SLO: <73.500MB -5.7%) vs baseline: +4.8% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 3.358ms (SLO: <4.750ms 📉 -29.3%) vs baseline: -0.3% Memory: ✅ 56.410MB (SLO: <66.500MB 📉 -15.2%) vs baseline: +4.7% ✅ appsec-postTime: ✅ 2.874ms (SLO: <6.750ms 📉 -57.4%) vs baseline: +0.3% Memory: ✅ 56.604MB (SLO: <66.500MB 📉 -14.9%) vs baseline: +4.9% ✅ appsec-telemetryTime: ✅ 3.374ms (SLO: <4.750ms 📉 -29.0%) vs baseline: +0.4% Memory: ✅ 56.513MB (SLO: <66.500MB 📉 -15.0%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.880ms (SLO: <2.000ms -6.0%) vs baseline: ~same Memory: ✅ 49.269MB (SLO: <51.500MB -4.3%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.878ms (SLO: <2.000ms -6.1%) vs baseline: +0.2% Memory: ✅ 45.956MB (SLO: <49.000MB -6.2%) vs baseline: +4.7% ✅ profilerTime: ✅ 1.912ms (SLO: <2.100ms -9.0%) vs baseline: -0.1% Memory: ✅ 52.714MB (SLO: <53.500MB 🟡 -1.5%) vs baseline: +5.1% ✅ resource-renamingTime: ✅ 3.339ms (SLO: <3.650ms -8.5%) vs baseline: -0.3% Memory: ✅ 56.515MB (SLO: <60.000MB -5.8%) vs baseline: +4.7% ✅ tracerTime: ✅ 3.349ms (SLO: <3.650ms -8.2%) vs baseline: ~same Memory: ✅ 56.464MB (SLO: <60.000MB -5.9%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.353ms (SLO: <3.650ms -8.1%) vs baseline: ~same Memory: ✅ 56.517MB (SLO: <60.000MB -5.8%) vs baseline: +4.9% 🟡 recursivecomputation - 8/8✅ deepTime: ✅ 310.437ms (SLO: <320.950ms -3.3%) vs baseline: -0.1% Memory: ✅ 37.532MB (SLO: <38.750MB -3.1%) vs baseline: +5.0% ✅ deep-profiledTime: ✅ 329.218ms (SLO: <359.150ms -8.3%) vs baseline: ~same Memory: ✅ 43.785MB (SLO: <46.000MB -4.8%) vs baseline: +4.9% ✅ mediumTime: ✅ 7.289ms (SLO: <7.400ms 🟡 -1.5%) vs baseline: ~same Memory: ✅ 36.667MB (SLO: <38.000MB -3.5%) vs baseline: +4.9% ✅ shallowTime: ✅ 1.013ms (SLO: <1.050ms -3.5%) vs baseline: +1.4% Memory: ✅ 36.608MB (SLO: <38.000MB -3.7%) vs baseline: +4.6%
|
brettlangdon
left a comment
There was a problem hiding this comment.
with this change, all layer size checks pass except for python 3.14 amd64 which fails by just a little bit
Description
datadog-lambda-layer precompiles all .py files to .pyc, but _monkey.py specifically checks for
patch.pyexactly.This change updates the check to look for
patch.pyorpatch.pyc, this way we can delete all thepatch.pyfiles in the lambda layer.Testing
Risks
Additional Notes