Skip to content

Add pathway propagation for SNS#7341

Merged
nayeem-kamal merged 12 commits intomasterfrom
nayeem-kamal/sns-pathway-propagation-2
Jul 19, 2024
Merged

Add pathway propagation for SNS#7341
nayeem-kamal merged 12 commits intomasterfrom
nayeem-kamal/sns-pathway-propagation-2

Conversation

@nayeem-kamal
Copy link
Contributor

@nayeem-kamal nayeem-kamal commented Jul 17, 2024 •
edited
Loading

What Does This Do

Adds support for injecting DSM pathway context into message attributes for SNS

Motivation

Additional Notes

Jira ticket: DSMS-21

@nayeem-kamal nayeem-kamal added the comp: data streams Data Streams Monitoring label Jul 17, 2024
@nayeem-kamal nayeem-kamal marked this pull request as ready for review July 17, 2024 17:46
@nayeem-kamal nayeem-kamal requested a review from a team as a code owner July 17, 2024 17:46
@pr-commenter
Copy link

pr-commenter bot commented Jul 17, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nayeem-kamal/sns-pathway-propagation-2
git_commit_date 1721321586 1721329756
git_commit_sha bfe00c1 36478e6
release_version 1.38.0-SNAPSHOT~bfe00c1b41 1.38.0-SNAPSHOT~36478e6ff7
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1721332191 1721332191
ci_job_id 577634506 577634506
ci_pipeline_id 39590027 39590027
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~36478e6ff7, baseline=1.38.0-SNAPSHOT~bfe00c1b41

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1043290
Total [baseline] (10.338 s) : 0, 10338137
Agent [candidate] (1.075 s) : 0, 1074540
Total [candidate] (10.365 s) : 0, 10364971
section appsec
Agent [baseline] (1.164 s) : 0, 1163790
Total [baseline] (10.475 s) : 0, 10475255
Agent [candidate] (1.189 s) : 0, 1189240
Total [candidate] (10.562 s) : 0, 10561614
section iast
Agent [baseline] (1.172 s) : 0, 1171578
Total [baseline] (10.729 s) : 0, 10729444
Agent [candidate] (1.172 s) : 0, 1171568
Total [candidate] (10.743 s) : 0, 10742909
section profiling
Agent [baseline] (1.242 s) : 0, 1241926
Total [baseline] (10.602 s) : 0, 10602385
Agent [candidate] (1.275 s) : 0, 1275371
Total [candidate] (10.612 s) : 0, 10611507
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.043 s -
Agent appsec 1.164 s 120.5 ms (11.6%)
Agent iast 1.172 s 128.288 ms (12.3%)
Agent profiling 1.242 s 198.637 ms (19.0%)
Total tracing 10.338 s -
Total appsec 10.475 s 137.118 ms (1.3%)
Total iast 10.729 s 391.307 ms (3.8%)
Total profiling 10.602 s 264.248 ms (2.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.075 s -
Agent appsec 1.189 s 114.7 ms (10.7%)
Agent iast 1.172 s 97.028 ms (9.0%)
Agent profiling 1.275 s 200.831 ms (18.7%)
Total tracing 10.365 s -
Total appsec 10.562 s 196.642 ms (1.9%)
Total iast 10.743 s 377.937 ms (3.6%)
Total profiling 10.612 s 246.536 ms (2.4%) 
gantt
    title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~36478e6ff7, baseline=1.38.0-SNAPSHOT~bfe00c1b41

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.272 ms) : 0, 666272
BytebuddyAgent [candidate] (673.997 ms) : 0, 673997
GlobalTracer [baseline] (305.291 ms) : 0, 305291
GlobalTracer [candidate] (306.804 ms) : 0, 306804
AppSec [baseline] (49.925 ms) : 0, 49925
AppSec [candidate] (50.356 ms) : 0, 50356
Remote Config [baseline] (674.391 µs) : 0, 674
Remote Config [candidate] (677.217 µs) : 0, 677
Telemetry [baseline] (7.652 ms) : 0, 7652
Telemetry [candidate] (7.684 ms) : 0, 7684
section appsec
BytebuddyAgent [baseline] (676.118 ms) : 0, 676118
BytebuddyAgent [candidate] (679.741 ms) : 0, 679741
GlobalTracer [baseline] (299.483 ms) : 0, 299483
GlobalTracer [candidate] (300.813 ms) : 0, 300813
AppSec [baseline] (153.938 ms) : 0, 153938
AppSec [candidate] (154.282 ms) : 0, 154282
Remote Config [baseline] (618.643 µs) : 0, 619
Remote Config [candidate] (621.874 µs) : 0, 622
Telemetry [baseline] (9.559 ms) : 0, 9559
Telemetry [candidate] (8.032 ms) : 0, 8032
IAST [baseline] (21.162 ms) : 0, 21162
IAST [candidate] (21.796 ms) : 0, 21796
section iast
BytebuddyAgent [baseline] (780.07 ms) : 0, 780070
BytebuddyAgent [candidate] (780.088 ms) : 0, 780088
GlobalTracer [baseline] (295.76 ms) : 0, 295760
GlobalTracer [candidate] (295.607 ms) : 0, 295607
AppSec [baseline] (48.35 ms) : 0, 48350
AppSec [candidate] (49.048 ms) : 0, 49048
Remote Config [baseline] (584.176 µs) : 0, 584
Remote Config [candidate] (588.276 µs) : 0, 588
Telemetry [baseline] (7.777 ms) : 0, 7777
Telemetry [candidate] (7.047 ms) : 0, 7047
IAST [baseline] (25.571 ms) : 0, 25571
IAST [candidate] (25.615 ms) : 0, 25615
section profiling
ProfilingAgent [baseline] (94.422 ms) : 0, 94422
ProfilingAgent [candidate] (97.259 ms) : 0, 97259
BytebuddyAgent [baseline] (663.356 ms) : 0, 663356
BytebuddyAgent [candidate] (668.62 ms) : 0, 668620
GlobalTracer [baseline] (388.607 ms) : 0, 388607
GlobalTracer [candidate] (391.096 ms) : 0, 391096
AppSec [baseline] (51.425 ms) : 0, 51425
AppSec [candidate] (52.486 ms) : 0, 52486
Remote Config [baseline] (645.568 µs) : 0, 646
Remote Config [candidate] (661.443 µs) : 0, 661
Telemetry [baseline] (7.37 ms) : 0, 7370
Telemetry [candidate] (7.496 ms) : 0, 7496
Profiling [baseline] (94.447 ms) : 0, 94447
Profiling [candidate] (97.284 ms) : 0, 97284
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~36478e6ff7, baseline=1.38.0-SNAPSHOT~bfe00c1b41

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043891
Total [baseline] (8.524 s) : 0, 8524177
Agent [candidate] (1.063 s) : 0, 1062731
Total [candidate] (8.503 s) : 0, 8502768
section iast
Agent [baseline] (1.17 s) : 0, 1170115
Total [baseline] (8.98 s) : 0, 8979570
Agent [candidate] (1.169 s) : 0, 1168857
Total [candidate] (8.986 s) : 0, 8985916
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1173945
Total [baseline] (8.96 s) : 0, 8960405
Agent [candidate] (1.171 s) : 0, 1170733
Total [candidate] (8.952 s) : 0, 8951624
section iast_TELEMETRY_OFF
Agent [baseline] (1.165 s) : 0, 1164796
Total [baseline] (8.946 s) : 0, 8946091
Agent [candidate] (1.168 s) : 0, 1168008
Total [candidate] (9.032 s) : 0, 9031591
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.044 s -
Agent iast 1.17 s 126.224 ms (12.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.174 s 130.054 ms (12.5%)
Agent iast_TELEMETRY_OFF 1.165 s 120.905 ms (11.6%)
Total tracing 8.524 s -
Total iast 8.98 s 455.392 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 8.96 s 436.228 ms (5.1%)
Total iast_TELEMETRY_OFF 8.946 s 421.914 ms (4.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent iast 1.169 s 106.126 ms (10.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.171 s 108.002 ms (10.2%)
Agent iast_TELEMETRY_OFF 1.168 s 105.277 ms (9.9%)
Total tracing 8.503 s -
Total iast 8.986 s 483.148 ms (5.7%)
Total iast_HARDCODED_SECRET_DISABLED 8.952 s 448.857 ms (5.3%)
Total iast_TELEMETRY_OFF 9.032 s 528.824 ms (6.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~36478e6ff7, baseline=1.38.0-SNAPSHOT~bfe00c1b41

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.539 ms) : 0, 666539
BytebuddyAgent [candidate] (665.159 ms) : 0, 665159
GlobalTracer [baseline] (305.474 ms) : 0, 305474
GlobalTracer [candidate] (304.694 ms) : 0, 304694
AppSec [baseline] (50.205 ms) : 0, 50205
AppSec [candidate] (49.995 ms) : 0, 49995
Remote Config [baseline] (670.552 µs) : 0, 671
Remote Config [candidate] (672.29 µs) : 0, 672
Telemetry [baseline] (7.578 ms) : 0, 7578
Telemetry [candidate] (7.673 ms) : 0, 7673
section iast
BytebuddyAgent [baseline] (780.594 ms) : 0, 780594
BytebuddyAgent [candidate] (779.693 ms) : 0, 779693
GlobalTracer [baseline] (295.247 ms) : 0, 295247
GlobalTracer [candidate] (295.694 ms) : 0, 295694
AppSec [baseline] (47.566 ms) : 0, 47566
AppSec [candidate] (47.308 ms) : 0, 47308
IAST [baseline] (25.68 ms) : 0, 25680
IAST [candidate] (25.075 ms) : 0, 25075
Remote Config [baseline] (595.048 µs) : 0, 595
Remote Config [candidate] (583.173 µs) : 0, 583
Telemetry [baseline] (7.015 ms) : 0, 7015
Telemetry [candidate] (6.999 ms) : 0, 6999
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (781.37 ms) : 0, 781370
BytebuddyAgent [candidate] (779.512 ms) : 0, 779512
GlobalTracer [baseline] (295.914 ms) : 0, 295914
GlobalTracer [candidate] (294.837 ms) : 0, 294837
AppSec [baseline] (48.363 ms) : 0, 48363
AppSec [candidate] (49.004 ms) : 0, 49004
IAST [baseline] (26.44 ms) : 0, 26440
IAST [candidate] (25.285 ms) : 0, 25285
Remote Config [baseline] (581.863 µs) : 0, 582
Remote Config [candidate] (592.695 µs) : 0, 593
Telemetry [baseline] (7.731 ms) : 0, 7731
Telemetry [candidate] (7.928 ms) : 0, 7928
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (777.593 ms) : 0, 777593
BytebuddyAgent [candidate] (776.526 ms) : 0, 776526
GlobalTracer [baseline] (294.925 ms) : 0, 294925
GlobalTracer [candidate] (294.777 ms) : 0, 294777
AppSec [baseline] (47.223 ms) : 0, 47223
AppSec [candidate] (47.243 ms) : 0, 47243
IAST [baseline] (23.936 ms) : 0, 23936
IAST [candidate] (28.466 ms) : 0, 28466
Remote Config [baseline] (597.907 µs) : 0, 598
Remote Config [candidate] (574.387 µs) : 0, 574
Telemetry [baseline] (7.038 ms) : 0, 7038
Telemetry [candidate] (6.825 ms) : 0, 6825
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-07-18T19:20:34 2024-07-18T19:27:24
git_branch master nayeem-kamal/sns-pathway-propagation-2
git_commit_date 1721321586 1721329756
git_commit_sha bfe00c1 36478e6
release_version 1.38.0-SNAPSHOT~bfe00c1b41 1.38.0-SNAPSHOT~36478e6ff7
start_time 2024-07-18T19:20:21 2024-07-18T19:27:10
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1721331185 1721331185
ci_job_id 577634509 577634509
ci_pipeline_id 39590027 39590027
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~36478e6ff7, baseline=1.38.0-SNAPSHOT~bfe00c1b41
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.322 ms) : 1303, 1341
.   : milestone, 1322,
appsec (1.72 ms) : 1698, 1743
.   : milestone, 1720,
appsec_no_iast (1.706 ms) : 1681, 1730
.   : milestone, 1706,
iast (1.482 ms) : 1459, 1504
.   : milestone, 1482,
profiling (1.539 ms) : 1513, 1564
.   : milestone, 1539,
tracing (1.447 ms) : 1423, 1471
.   : milestone, 1447,
section candidate
no_agent (1.329 ms) : 1309, 1349
.   : milestone, 1329,
appsec (1.692 ms) : 1668, 1715
.   : milestone, 1692,
appsec_no_iast (1.702 ms) : 1678, 1725
.   : milestone, 1702,
iast (1.469 ms) : 1447, 1492
.   : milestone, 1469,
profiling (1.486 ms) : 1461, 1510
.   : milestone, 1486,
tracing (1.448 ms) : 1424, 1473
.   : milestone, 1448,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.322 ms [1.303 ms, 1.341 ms] -
appsec 1.72 ms [1.698 ms, 1.743 ms] 398.273 µs (30.1%)
appsec_no_iast 1.706 ms [1.681 ms, 1.73 ms] 383.734 µs (29.0%)
iast 1.482 ms [1.459 ms, 1.504 ms] 159.666 µs (12.1%)
profiling 1.539 ms [1.513 ms, 1.564 ms] 216.832 µs (16.4%)
tracing 1.447 ms [1.423 ms, 1.471 ms] 125.133 µs (9.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.329 ms [1.309 ms, 1.349 ms] -
appsec 1.692 ms [1.668 ms, 1.715 ms] 362.793 µs (27.3%)
appsec_no_iast 1.702 ms [1.678 ms, 1.725 ms] 372.779 µs (28.1%)
iast 1.469 ms [1.447 ms, 1.492 ms] 140.649 µs (10.6%)
profiling 1.486 ms [1.461 ms, 1.51 ms] 157.022 µs (11.8%)
tracing 1.448 ms [1.424 ms, 1.473 ms] 119.375 µs (9.0%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~36478e6ff7, baseline=1.38.0-SNAPSHOT~bfe00c1b41
    dateFormat X
    axisFormat %s
section baseline
no_agent (361.535 µs) : 341, 382
.   : milestone, 362,
iast (473.023 µs) : 452, 494
.   : milestone, 473,
iast_FULL (542.158 µs) : 521, 563
.   : milestone, 542,
iast_GLOBAL (498.645 µs) : 477, 520
.   : milestone, 499,
iast_HARDCODED_SECRET_DISABLED (479.177 µs) : 458, 500
.   : milestone, 479,
iast_INACTIVE (450.291 µs) : 429, 472
.   : milestone, 450,
iast_TELEMETRY_OFF (467.125 µs) : 446, 489
.   : milestone, 467,
tracing (428.692 µs) : 409, 449
.   : milestone, 429,
section candidate
no_agent (356.103 µs) : 337, 375
.   : milestone, 356,
iast (478.004 µs) : 457, 499
.   : milestone, 478,
iast_FULL (547.067 µs) : 526, 568
.   : milestone, 547,
iast_GLOBAL (498.34 µs) : 477, 520
.   : milestone, 498,
iast_HARDCODED_SECRET_DISABLED (476.324 µs) : 455, 498
.   : milestone, 476,
iast_INACTIVE (451.147 µs) : 430, 473
.   : milestone, 451,
iast_TELEMETRY_OFF (466.788 µs) : 446, 488
.   : milestone, 467,
tracing (435.184 µs) : 415, 455
.   : milestone, 435,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 361.535 µs [341.265 µs, 381.804 µs] -
iast 473.023 µs [452.094 µs, 493.952 µs] 111.489 µs (30.8%)
iast_FULL 542.158 µs [521.127 µs, 563.19 µs] 180.624 µs (50.0%)
iast_GLOBAL 498.645 µs [477.03 µs, 520.26 µs] 137.11 µs (37.9%)
iast_HARDCODED_SECRET_DISABLED 479.177 µs [458.046 µs, 500.307 µs] 117.642 µs (32.5%)
iast_INACTIVE 450.291 µs [428.81 µs, 471.771 µs] 88.756 µs (24.5%)
iast_TELEMETRY_OFF 467.125 µs [445.688 µs, 488.562 µs] 105.59 µs (29.2%)
tracing 428.692 µs [408.813 µs, 448.572 µs] 67.158 µs (18.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 356.103 µs [336.739 µs, 375.467 µs] -
iast 478.004 µs [456.709 µs, 499.298 µs] 121.901 µs (34.2%)
iast_FULL 547.067 µs [525.763 µs, 568.372 µs] 190.965 µs (53.6%)
iast_GLOBAL 498.34 µs [476.712 µs, 519.968 µs] 142.237 µs (39.9%)
iast_HARDCODED_SECRET_DISABLED 476.324 µs [455.092 µs, 497.557 µs] 120.221 µs (33.8%)
iast_INACTIVE 451.147 µs [429.587 µs, 472.707 µs] 95.044 µs (26.7%)
iast_TELEMETRY_OFF 466.788 µs [445.869 µs, 487.706 µs] 110.685 µs (31.1%)
tracing 435.184 µs [414.972 µs, 455.395 µs] 79.081 µs (22.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nayeem-kamal/sns-pathway-propagation-2
git_commit_date 1721321586 1721329756
git_commit_sha bfe00c1 36478e6
release_version 1.38.0-SNAPSHOT~bfe00c1b41 1.38.0-SNAPSHOT~36478e6ff7
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1721331834 1721331834
ci_job_id 577634511 577634511
ci_pipeline_id 39590027 39590027
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~36478e6ff7, baseline=1.38.0-SNAPSHOT~bfe00c1b41
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.476 s) : 15476000, 15476000
.   : milestone, 15476000,
appsec (15.137 s) : 15137000, 15137000
.   : milestone, 15137000,
iast (18.967 s) : 18967000, 18967000
.   : milestone, 18967000,
iast_GLOBAL (17.911 s) : 17911000, 17911000
.   : milestone, 17911000,
profiling (15.331 s) : 15331000, 15331000
.   : milestone, 15331000,
tracing (15.252 s) : 15252000, 15252000
.   : milestone, 15252000,
section candidate
no_agent (15.325 s) : 15325000, 15325000
.   : milestone, 15325000,
appsec (14.838 s) : 14838000, 14838000
.   : milestone, 14838000,
iast (18.711 s) : 18711000, 18711000
.   : milestone, 18711000,
iast_GLOBAL (17.886 s) : 17886000, 17886000
.   : milestone, 17886000,
profiling (15.227 s) : 15227000, 15227000
.   : milestone, 15227000,
tracing (15.219 s) : 15219000, 15219000
.   : milestone, 15219000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.476 s [15.476 s, 15.476 s] -
appsec 15.137 s [15.137 s, 15.137 s] -339.0 ms (-2.2%)
iast 18.967 s [18.967 s, 18.967 s] 3.491 s (22.6%)
iast_GLOBAL 17.911 s [17.911 s, 17.911 s] 2.435 s (15.7%)
profiling 15.331 s [15.331 s, 15.331 s] -145.0 ms (-0.9%)
tracing 15.252 s [15.252 s, 15.252 s] -224.0 ms (-1.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.325 s [15.325 s, 15.325 s] -
appsec 14.838 s [14.838 s, 14.838 s] -487.0 ms (-3.2%)
iast 18.711 s [18.711 s, 18.711 s] 3.386 s (22.1%)
iast_GLOBAL 17.886 s [17.886 s, 17.886 s] 2.561 s (16.7%)
profiling 15.227 s [15.227 s, 15.227 s] -98.0 ms (-0.6%)
tracing 15.219 s [15.219 s, 15.219 s] -106.0 ms (-0.7%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~36478e6ff7, baseline=1.38.0-SNAPSHOT~bfe00c1b41
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.462 ms) : 1450, 1473
.   : milestone, 1462,
appsec (2.206 ms) : 2171, 2241
.   : milestone, 2206,
iast (1.96 ms) : 1919, 2001
.   : milestone, 1960,
iast_GLOBAL (2.01 ms) : 1967, 2053
.   : milestone, 2010,
profiling (1.854 ms) : 1819, 1889
.   : milestone, 1854,
tracing (1.832 ms) : 1798, 1865
.   : milestone, 1832,
section candidate
no_agent (1.457 ms) : 1446, 1468
.   : milestone, 1457,
appsec (2.22 ms) : 2185, 2255
.   : milestone, 2220,
iast (1.951 ms) : 1910, 1993
.   : milestone, 1951,
iast_GLOBAL (2.003 ms) : 1960, 2045
.   : milestone, 2003,
profiling (2.308 ms) : 2064, 2552
.   : milestone, 2308,
tracing (1.832 ms) : 1799, 1865
.   : milestone, 1832,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.45 ms, 1.473 ms] -
appsec 2.206 ms [2.171 ms, 2.241 ms] 744.327 µs (50.9%)
iast 1.96 ms [1.919 ms, 2.001 ms] 498.145 µs (34.1%)
iast_GLOBAL 2.01 ms [1.967 ms, 2.053 ms] 548.499 µs (37.5%)
profiling 1.854 ms [1.819 ms, 1.889 ms] 391.79 µs (26.8%)
tracing 1.832 ms [1.798 ms, 1.865 ms] 369.885 µs (25.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.457 ms [1.446 ms, 1.468 ms] -
appsec 2.22 ms [2.185 ms, 2.255 ms] 762.684 µs (52.3%)
iast 1.951 ms [1.91 ms, 1.993 ms] 494.367 µs (33.9%)
iast_GLOBAL 2.003 ms [1.96 ms, 2.045 ms] 545.482 µs (37.4%)
profiling 2.308 ms [2.064 ms, 2.552 ms] 851.373 µs (58.4%)
tracing 1.832 ms [1.799 ms, 1.865 ms] 374.838 µs (25.7%)

@nayeem-kamal nayeem-kamal requested a review from a team as a code owner July 17, 2024 19:11
vandonr
vandonr reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@vandonr vandonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, modulo the added complexity on getting the topic in v2

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jul 18, 2024 •
edited
Loading

Library Vulnerabilities

Critical badge  High badge  Medium badge  Low badge

@nayeem-kamal nayeem-kamal requested a review from vandonr July 18, 2024 14:38
@nayeem-kamal nayeem-kamal requested a review from vandonr July 18, 2024 18:06
@PerfectSlayer PerfectSlayer changed the title Pathway propagation for SNS Add pathway propagation for SNS Jul 19, 2024
@nayeem-kamal nayeem-kamal merged commit bf41350 into master Jul 19, 2024
@nayeem-kamal nayeem-kamal deleted the nayeem-kamal/sns-pathway-propagation-2 branch July 19, 2024 12:46
@github-actions github-actions bot added this to the 1.38.0 milestone Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@vandonr vandonr vandonr approved these changes

@piochelepiotr piochelepiotr Awaiting requested review from piochelepiotr

@mcculls mcculls Awaiting requested review from mcculls mcculls was automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: data streams Data Streams Monitoring

Projects

None yet

Milestone

1.38.0

Development

Successfully merging this pull request may close these issues.

3 participants

@nayeem-kamal @PerfectSlayer @vandonr