Reduce VirtualThread tests flakiness#10834
Reduce VirtualThread tests flakiness#10834gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom
Conversation
Introduce generic blockUntil method to wait for trace pattern before evaluating them
amarziali
left a comment
There was a problem hiding this comment.
The approach is cleaner however I don't know if this will reduce the flakiness since it waits similarly for the same stuff
I used to check for the jobs to complete. Now I check for the spans to be written. |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 65 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~6e8d9738c5, baseline=1.61.0-SNAPSHOT~fd65c0aa59
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056035
Total [baseline] (8.852 s) : 0, 8851774
Agent [candidate] (1.072 s) : 0, 1071931
Total [candidate] (8.885 s) : 0, 8885201
section iast
Agent [baseline] (1.222 s) : 0, 1222450
Total [baseline] (9.539 s) : 0, 9539291
Agent [candidate] (1.236 s) : 0, 1236074
Total [candidate] (9.601 s) : 0, 9601289
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~6e8d9738c5, baseline=1.61.0-SNAPSHOT~fd65c0aa59
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (627.125 ms) : 0, 627125
BytebuddyAgent [candidate] (636.85 ms) : 0, 636850
AgentMeter [baseline] (28.976 ms) : 0, 28976
AgentMeter [candidate] (29.464 ms) : 0, 29464
GlobalTracer [baseline] (256.241 ms) : 0, 256241
GlobalTracer [candidate] (259.726 ms) : 0, 259726
AppSec [baseline] (31.446 ms) : 0, 31446
AppSec [candidate] (32.023 ms) : 0, 32023
Debugger [baseline] (58.569 ms) : 0, 58569
Debugger [candidate] (59.523 ms) : 0, 59523
Remote Config [baseline] (618.454 µs) : 0, 618
Remote Config [candidate] (617.945 µs) : 0, 618
Telemetry [baseline] (8.616 ms) : 0, 8616
Telemetry [candidate] (8.843 ms) : 0, 8843
Flare Poller [baseline] (7.224 ms) : 0, 7224
Flare Poller [candidate] (7.349 ms) : 0, 7349
section iast
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (793.287 ms) : 0, 793287
BytebuddyAgent [candidate] (802.741 ms) : 0, 802741
AgentMeter [baseline] (11.267 ms) : 0, 11267
AgentMeter [candidate] (11.587 ms) : 0, 11587
GlobalTracer [baseline] (246.355 ms) : 0, 246355
GlobalTracer [candidate] (249.161 ms) : 0, 249161
IAST [baseline] (25.066 ms) : 0, 25066
IAST [candidate] (25.467 ms) : 0, 25467
AppSec [baseline] (26.262 ms) : 0, 26262
AppSec [candidate] (26.694 ms) : 0, 26694
Debugger [baseline] (62.842 ms) : 0, 62842
Debugger [candidate] (62.854 ms) : 0, 62854
Remote Config [baseline] (506.119 µs) : 0, 506
Remote Config [candidate] (510.545 µs) : 0, 511
Telemetry [baseline] (14.859 ms) : 0, 14859
Telemetry [candidate] (14.696 ms) : 0, 14696
Flare Poller [baseline] (4.849 ms) : 0, 4849
Flare Poller [candidate] (4.88 ms) : 0, 4880
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~6e8d9738c5, baseline=1.61.0-SNAPSHOT~fd65c0aa59
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1067356
Total [baseline] (11.025 s) : 0, 11025215
Agent [candidate] (1.058 s) : 0, 1058241
Total [candidate] (11.047 s) : 0, 11046796
section appsec
Agent [baseline] (1.245 s) : 0, 1245149
Total [baseline] (11.12 s) : 0, 11119650
Agent [candidate] (1.256 s) : 0, 1255529
Total [candidate] (11.12 s) : 0, 11120241
section iast
Agent [baseline] (1.235 s) : 0, 1235420
Total [baseline] (11.394 s) : 0, 11393665
Agent [candidate] (1.228 s) : 0, 1228049
Total [candidate] (11.413 s) : 0, 11412522
section profiling
Agent [baseline] (1.192 s) : 0, 1191894
Total [baseline] (11.124 s) : 0, 11124340
Agent [candidate] (1.18 s) : 0, 1180061
Total [candidate] (11.06 s) : 0, 11059622
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~6e8d9738c5, baseline=1.61.0-SNAPSHOT~fd65c0aa59
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.216 ms) : 0, 1216
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (632.902 ms) : 0, 632902
BytebuddyAgent [candidate] (629.126 ms) : 0, 629126
AgentMeter [baseline] (29.279 ms) : 0, 29279
AgentMeter [candidate] (29.099 ms) : 0, 29099
GlobalTracer [baseline] (258.216 ms) : 0, 258216
GlobalTracer [candidate] (256.985 ms) : 0, 256985
AppSec [baseline] (31.692 ms) : 0, 31692
AppSec [candidate] (31.444 ms) : 0, 31444
Debugger [baseline] (59.83 ms) : 0, 59830
Debugger [candidate] (59.442 ms) : 0, 59442
Remote Config [baseline] (614.131 µs) : 0, 614
Remote Config [candidate] (614.944 µs) : 0, 615
Telemetry [baseline] (8.738 ms) : 0, 8738
Telemetry [candidate] (8.693 ms) : 0, 8693
Flare Poller [baseline] (8.795 ms) : 0, 8795
Flare Poller [candidate] (5.67 ms) : 0, 5670
section appsec
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (657.481 ms) : 0, 657481
BytebuddyAgent [candidate] (663.773 ms) : 0, 663773
AgentMeter [baseline] (12.09 ms) : 0, 12090
AgentMeter [candidate] (12.124 ms) : 0, 12124
GlobalTracer [baseline] (257.983 ms) : 0, 257983
GlobalTracer [candidate] (259.496 ms) : 0, 259496
IAST [baseline] (24.063 ms) : 0, 24063
IAST [candidate] (24.269 ms) : 0, 24269
AppSec [baseline] (177.26 ms) : 0, 177260
AppSec [candidate] (178.647 ms) : 0, 178647
Debugger [baseline] (65.705 ms) : 0, 65705
Debugger [candidate] (66.21 ms) : 0, 66210
Remote Config [baseline] (583.144 µs) : 0, 583
Remote Config [candidate] (573.862 µs) : 0, 574
Telemetry [baseline] (9.001 ms) : 0, 9001
Telemetry [candidate] (9.097 ms) : 0, 9097
Flare Poller [baseline] (3.61 ms) : 0, 3610
Flare Poller [candidate] (3.734 ms) : 0, 3734
section iast
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (802.872 ms) : 0, 802872
BytebuddyAgent [candidate] (796.644 ms) : 0, 796644
AgentMeter [baseline] (11.561 ms) : 0, 11561
AgentMeter [candidate] (11.345 ms) : 0, 11345
GlobalTracer [baseline] (248.029 ms) : 0, 248029
GlobalTracer [candidate] (247.548 ms) : 0, 247548
IAST [baseline] (25.301 ms) : 0, 25301
IAST [candidate] (25.18 ms) : 0, 25180
AppSec [baseline] (26.547 ms) : 0, 26547
AppSec [candidate] (26.471 ms) : 0, 26471
Debugger [baseline] (64.311 ms) : 0, 64311
Debugger [candidate] (64.059 ms) : 0, 64059
Remote Config [baseline] (525.635 µs) : 0, 526
Remote Config [candidate] (527.869 µs) : 0, 528
Telemetry [baseline] (14.207 ms) : 0, 14207
Telemetry [candidate] (14.385 ms) : 0, 14385
Flare Poller [baseline] (4.724 ms) : 0, 4724
Flare Poller [candidate] (4.726 ms) : 0, 4726
section profiling
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.163 ms) : 0, 1163
BytebuddyAgent [baseline] (688.53 ms) : 0, 688530
BytebuddyAgent [candidate] (681.761 ms) : 0, 681761
AgentMeter [baseline] (8.735 ms) : 0, 8735
AgentMeter [candidate] (8.597 ms) : 0, 8597
GlobalTracer [baseline] (217.103 ms) : 0, 217103
GlobalTracer [candidate] (214.928 ms) : 0, 214928
AppSec [baseline] (32.372 ms) : 0, 32372
AppSec [candidate] (31.864 ms) : 0, 31864
Debugger [baseline] (64.352 ms) : 0, 64352
Debugger [candidate] (63.722 ms) : 0, 63722
Remote Config [baseline] (610.058 µs) : 0, 610
Remote Config [candidate] (595.464 µs) : 0, 595
Telemetry [baseline] (9.763 ms) : 0, 9763
Telemetry [candidate] (9.721 ms) : 0, 9721
Flare Poller [baseline] (3.54 ms) : 0, 3540
Flare Poller [candidate] (3.492 ms) : 0, 3492
ProfilingAgent [baseline] (94.489 ms) : 0, 94489
ProfilingAgent [candidate] (93.515 ms) : 0, 93515
Profiling [baseline] (95.062 ms) : 0, 95062
Profiling [candidate] (94.073 ms) : 0, 94073
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 20 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~6e8d9738c5, baseline=1.61.0-SNAPSHOT~fd65c0aa59
dateFormat X
axisFormat %s
section baseline
no_agent (1.17 ms) : 1159, 1182
. : milestone, 1170,
iast (3.26 ms) : 3213, 3306
. : milestone, 3260,
iast_FULL (5.865 ms) : 5806, 5924
. : milestone, 5865,
iast_GLOBAL (3.438 ms) : 3387, 3489
. : milestone, 3438,
profiling (1.997 ms) : 1979, 2014
. : milestone, 1997,
tracing (1.77 ms) : 1753, 1786
. : milestone, 1770,
section candidate
no_agent (1.189 ms) : 1178, 1201
. : milestone, 1189,
iast (3.232 ms) : 3188, 3275
. : milestone, 3232,
iast_FULL (5.973 ms) : 5912, 6033
. : milestone, 5973,
iast_GLOBAL (3.355 ms) : 3310, 3401
. : milestone, 3355,
profiling (2.306 ms) : 2284, 2328
. : milestone, 2306,
tracing (1.813 ms) : 1797, 1830
. : milestone, 1813,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~6e8d9738c5, baseline=1.61.0-SNAPSHOT~fd65c0aa59
dateFormat X
axisFormat %s
section baseline
no_agent (18.689 ms) : 18504, 18873
. : milestone, 18689,
appsec (18.586 ms) : 18399, 18774
. : milestone, 18586,
code_origins (18.065 ms) : 17882, 18249
. : milestone, 18065,
iast (17.764 ms) : 17587, 17942
. : milestone, 17764,
profiling (18.67 ms) : 18481, 18859
. : milestone, 18670,
tracing (17.785 ms) : 17609, 17961
. : milestone, 17785,
section candidate
no_agent (18.094 ms) : 17905, 18283
. : milestone, 18094,
appsec (18.873 ms) : 18684, 19063
. : milestone, 18873,
code_origins (17.554 ms) : 17382, 17727
. : milestone, 17554,
iast (17.833 ms) : 17656, 18010
. : milestone, 17833,
profiling (18.479 ms) : 18294, 18664
. : milestone, 18479,
tracing (17.713 ms) : 17539, 17886
. : milestone, 17713,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~6e8d9738c5, baseline=1.61.0-SNAPSHOT~fd65c0aa59
dateFormat X
axisFormat %s
section baseline
no_agent (1.486 ms) : 1474, 1498
. : milestone, 1486,
appsec (3.835 ms) : 3612, 4058
. : milestone, 3835,
iast (2.264 ms) : 2195, 2333
. : milestone, 2264,
iast_GLOBAL (2.315 ms) : 2245, 2385
. : milestone, 2315,
profiling (2.117 ms) : 2061, 2173
. : milestone, 2117,
tracing (2.066 ms) : 2013, 2119
. : milestone, 2066,
section candidate
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (3.831 ms) : 3608, 4055
. : milestone, 3831,
iast (2.27 ms) : 2201, 2339
. : milestone, 2270,
iast_GLOBAL (2.314 ms) : 2244, 2383
. : milestone, 2314,
profiling (2.104 ms) : 2049, 2159
. : milestone, 2104,
tracing (2.072 ms) : 2019, 2126
. : milestone, 2072,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~6e8d9738c5, baseline=1.61.0-SNAPSHOT~fd65c0aa59
dateFormat X
axisFormat %s
section baseline
no_agent (14.757 s) : 14757000, 14757000
. : milestone, 14757000,
appsec (14.959 s) : 14959000, 14959000
. : milestone, 14959000,
iast (18.342 s) : 18342000, 18342000
. : milestone, 18342000,
iast_GLOBAL (17.72 s) : 17720000, 17720000
. : milestone, 17720000,
profiling (14.949 s) : 14949000, 14949000
. : milestone, 14949000,
tracing (15.39 s) : 15390000, 15390000
. : milestone, 15390000,
section candidate
no_agent (15.318 s) : 15318000, 15318000
. : milestone, 15318000,
appsec (15.102 s) : 15102000, 15102000
. : milestone, 15102000,
iast (18.237 s) : 18237000, 18237000
. : milestone, 18237000,
iast_GLOBAL (17.945 s) : 17945000, 17945000
. : milestone, 17945000,
profiling (14.867 s) : 14867000, 14867000
. : milestone, 14867000,
tracing (15.179 s) : 15179000, 15179000
. : milestone, 15179000,
|
243ec0b
into
master
What Does This Do
This PR aims to reduce flakiness when checking for trace structure using async calls.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.