Skip to content

[CHORE] [NO JIRA] Cleanup of unused imports and param docs#1312

Open
sbarrio wants to merge 2 commits into
developfrom
sbarrio/chore/import-and-parameter-cleanup
Open

[CHORE] [NO JIRA] Cleanup of unused imports and param docs#1312
sbarrio wants to merge 2 commits into
developfrom
sbarrio/chore/import-and-parameter-cleanup

Conversation

@sbarrio

@sbarrio sbarrio commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

It cleans up unused imports and also fixes missing or wrong parameter documentation on part of the SDK's API.

Motivation

We should not have unused imports or wrongly documented functions.

Additional Notes

Thanks to @abrooksv for raising 🙌

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@sbarrio sbarrio requested review from a team as code owners June 18, 2026 09:43
Copilot AI review requested due to automatic review settings June 18, 2026 09:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Cleanup-focused PR that removes unused imports across iOS/Android modules and aligns public-facing API documentation (KDoc/SwiftDoc/README) with the current SDK configuration surface.

Changes:

  • Removed unused imports in WebView and Core Android/iOS native modules.
  • Updated README config example to use the correct resourceTraceSampleRate field and simplified the logEventMapper example.
  • Corrected/updated parameter documentation for native APIs (e.g., added fingerprint param doc; removed stale param docs).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/react-native-webview/ios/Sources/RCTDatadogWebViewManager.mm Removes an unused umbrella import in the iOS WebView manager.
packages/react-native-webview/android/src/newarch/com/datadog/reactnative/webview/DdSdkReactNativeWebViewPackage.kt Removes unused WebView module imports in new architecture package.
packages/core/README.md Updates configuration example field name and refines mapper example (but currently introduces a syntax issue).
packages/core/ios/Sources/DdSdkConfiguration.swift Removes stale parameter documentation for Trace configuration.
packages/core/ios/Sources/DdLogsImplementation.swift Updates parameter doc name for logger configuration initializer.
packages/core/android/src/main/kotlin/com/datadog/reactnative/DdSdkReactNativePackage.kt Removes an unused Android import.
packages/core/android/src/main/kotlin/com/datadog/reactnative/DdSdkConfiguration.kt Removes an unused Android import.
packages/core/android/src/main/kotlin/com/datadog/reactnative/DdRumImplementation.kt Adds missing KDoc for the fingerprint parameter on addError.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/core/README.md Outdated
Comment thread packages/core/ios/Sources/DdLogsImplementation.swift Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants