[CHORE] [NO JIRA] Cleanup of unused imports and param docs#1312
Open
sbarrio wants to merge 2 commits into
Open
[CHORE] [NO JIRA] Cleanup of unused imports and param docs#1312sbarrio wants to merge 2 commits into
sbarrio wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Cleanup-focused PR that removes unused imports across iOS/Android modules and aligns public-facing API documentation (KDoc/SwiftDoc/README) with the current SDK configuration surface.
Changes:
- Removed unused imports in WebView and Core Android/iOS native modules.
- Updated README config example to use the correct
resourceTraceSampleRatefield and simplified thelogEventMapperexample. - Corrected/updated parameter documentation for native APIs (e.g., added
fingerprintparam doc; removed stale param docs).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react-native-webview/ios/Sources/RCTDatadogWebViewManager.mm | Removes an unused umbrella import in the iOS WebView manager. |
| packages/react-native-webview/android/src/newarch/com/datadog/reactnative/webview/DdSdkReactNativeWebViewPackage.kt | Removes unused WebView module imports in new architecture package. |
| packages/core/README.md | Updates configuration example field name and refines mapper example (but currently introduces a syntax issue). |
| packages/core/ios/Sources/DdSdkConfiguration.swift | Removes stale parameter documentation for Trace configuration. |
| packages/core/ios/Sources/DdLogsImplementation.swift | Updates parameter doc name for logger configuration initializer. |
| packages/core/android/src/main/kotlin/com/datadog/reactnative/DdSdkReactNativePackage.kt | Removes an unused Android import. |
| packages/core/android/src/main/kotlin/com/datadog/reactnative/DdSdkConfiguration.kt | Removes an unused Android import. |
| packages/core/android/src/main/kotlin/com/datadog/reactnative/DdRumImplementation.kt | Adds missing KDoc for the fingerprint parameter on addError. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
git-thuerk-done
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It cleans up unused imports and also fixes missing or wrong parameter documentation on part of the SDK's API.
Motivation
We should not have unused imports or wrongly documented functions.
Additional Notes
Thanks to @abrooksv for raising 🙌
Review checklist (to be filled by reviewers)