Skip to content

fix: approve esbuild in pnpm allowBuilds to unblock Vercel install - #112

Merged
DataDave-Dev merged 1 commit into
mainfrom
fix/pnpm-allowbuilds-esbuild
Jun 18, 2026
Merged

fix: approve esbuild in pnpm allowBuilds to unblock Vercel install#112
DataDave-Dev merged 1 commit into
mainfrom
fix/pnpm-allowbuilds-esbuild

Conversation

@DataDave-Dev

@DataDave-Dev DataDave-Dev commented Jun 18, 2026

Copy link
Copy Markdown
Owner

Problema

El deploy de main falla en pnpm install con ERR_PNPM_IGNORED_BUILDS (esbuild).

PR #111 añadió drizzle-kit, que arrastra esbuild. El build script de esbuild quedó como placeholder sin decidir (esbuild: set this to true or false) y, además, ese PR había cambiado el formato a onlyBuiltDependencies, que no es el que honra la versión de pnpm del proyecto (usa el mapa allowBuilds). Resultado: pnpm rechaza continuar.

Fix

Restaurar allowBuilds con valores booleanos y aprobar esbuild:

allowBuilds:
  core-js: false
  esbuild: true
  sharp: false
  unrs-resolver: false

Verificación

  • rm -rf node_modules && pnpm install → exit 0, sin reescribir placeholders
  • pnpm test ✓ (55)
  • pnpm build

Summary by CodeRabbit

  • Chores
    • Updated dependency build configuration to refine which packages are built during installation, providing better control over build processes and optimizing build performance.

PR #111 added drizzle-kit (which pulls esbuild). esbuild's build script
was left undecided as a placeholder in pnpm-workspace.yaml, and the prior
change to onlyBuiltDependencies isn't the format this pnpm honors, so the
Vercel install failed with ERR_PNPM_IGNORED_BUILDS. Set esbuild: true and
keep the other builds disabled.
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5c995c24-34f1-48f8-ae40-5a83cd3ab4c9

📥 Commits

Reviewing files that changed from the base of the PR and between 890bad8 and 06d8b41.

📒 Files selected for processing (1)
  • pnpm-workspace.yaml

📝 Walkthrough

Walkthrough

pnpm-workspace.yaml replaces the onlyBuiltDependencies: [esbuild] field with an allowBuilds map that explicitly sets esbuild: true and core-js, sharp, and unrs-resolver to false.

Changes

pnpm workspace build allowlist

Layer / File(s) Summary
allowBuilds mapping
pnpm-workspace.yaml
Replaces onlyBuiltDependencies: [esbuild] with an allowBuilds map that enables builds for esbuild and explicitly disables them for core-js, sharp, and unrs-resolver.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • DataDave-Dev/weftmap#109: Also modifies pnpm-workspace.yaml's allowBuilds mapping, removing/disabling sharp and unrs-resolver from the build allowlist.

Poem

🐇 A config so small, yet mighty in deed,
onlyBuiltDependencies — gone with great speed!
allowBuilds arrives with a map in its paw,
esbuild says yes, the others say "naw."
The workspace hops forward, neat, tidy, and true! 🌿

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description provides detailed context about the problem, the fix, and verification steps, but does not follow the required Spanish template structure with sections, type checkbox, and checklist items. Restructure the description to follow the template: add 'Qué hace' section, select a 'Tipo' checkbox (fix), and complete all checklist items confirming tests pass.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: approving esbuild in pnpm allowBuilds to fix the Vercel install blocking issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pnpm-allowbuilds-esbuild

Comment @coderabbitai help to get the list of available commands and usage tips.

@DataDave-Dev
DataDave-Dev merged commit 59daa1d into main Jun 18, 2026
0 of 2 checks passed
@DataDave-Dev
DataDave-Dev deleted the fix/pnpm-allowbuilds-esbuild branch June 18, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant