fix: approve esbuild in pnpm allowBuilds to unblock Vercel install - #112
Conversation
PR #111 added drizzle-kit (which pulls esbuild). esbuild's build script was left undecided as a placeholder in pnpm-workspace.yaml, and the prior change to onlyBuiltDependencies isn't the format this pnpm honors, so the Vercel install failed with ERR_PNPM_IGNORED_BUILDS. Set esbuild: true and keep the other builds disabled.
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
Changespnpm workspace build allowlist
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Problema
El deploy de
mainfalla enpnpm installconERR_PNPM_IGNORED_BUILDS(esbuild).PR #111 añadió
drizzle-kit, que arrastraesbuild. El build script de esbuild quedó como placeholder sin decidir (esbuild: set this to true or false) y, además, ese PR había cambiado el formato aonlyBuiltDependencies, que no es el que honra la versión de pnpm del proyecto (usa el mapaallowBuilds). Resultado: pnpm rechaza continuar.Fix
Restaurar
allowBuildscon valores booleanos y aprobar esbuild:Verificación
rm -rf node_modules && pnpm install→ exit 0, sin reescribir placeholderspnpm test✓ (55)pnpm build✓Summary by CodeRabbit